mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-20 13:52:40 +01:00
Make the buildables list a little nicer.
Summary: Depends on D7501. This just renders the buildable's actual object name onto the list, so you can see at a glance what the buildable represents. I'd like to also pull across a list of builds of this buildable and change the bar color, but I'm not quite sure how to do that in the search architecture without N+1 querying. Test Plan: Looked at the buildable list and it looked like this: {F78555} Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley CC: Korvin, epriestley, aran Maniphest Tasks: T1049 Differential Revision: https://secure.phabricator.com/D7502
This commit is contained in:
parent
b6c88bd6c1
commit
8cae7f999f
2 changed files with 2 additions and 0 deletions
|
@ -37,6 +37,7 @@ final class HarbormasterBuildableListController
|
|||
|
||||
$item = id(new PHUIObjectItemView())
|
||||
->setHeader(pht('Buildable %d', $buildable->getID()));
|
||||
$item->addAttribute($buildable->getBuildableHandle()->getFullName());
|
||||
|
||||
if ($id) {
|
||||
$item->setHref("/B{$id}");
|
||||
|
|
|
@ -11,6 +11,7 @@ final class HarbormasterBuildableSearchEngine
|
|||
|
||||
public function buildQueryFromSavedQuery(PhabricatorSavedQuery $saved) {
|
||||
$query = id(new HarbormasterBuildableQuery());
|
||||
$query->needBuildableHandles(true);
|
||||
|
||||
return $query;
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue