revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-20 09:18:48 +02:00
Code Issues Releases Wiki Activity

Allow lint codes to be up to 128 bytes long

Browse source 
Summary:
Fixes T9145. We currently restrict lint codes to 32 bytes, but PHPCS generates codes like "PHPCS.E.PEAR.Comments.Messages.Line.TooLong".

These codes seem reasonable as codes, and we don't currently have any key-length problems or other technical concerns with simply raising the size of this column.

Test Plan: Ran `bin/storage upgrade` to pick up adjustments.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9145

Differential Revision: https://secure.phabricator.com/D14166
This commit is contained in:
epriestley 2015-09-25 10:42:57 -07:00
parent 284fe0fe51
commit 8ce90a7c42
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/harbormaster/storage/build/HarbormasterBuildLintMessage.php
View file

@ -104,7 +104,7 @@ final class HarbormasterBuildLintMessage
'path' => 'text',
'line' => 'uint32?',
'characterOffset' => 'uint32?',
'code' => 'text32',
'code' => 'text128',
'severity' => 'text32',
'name' => 'text255',
),