revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-23 12:09:12 +01:00
Code Issues Releases Wiki Activity

Fix Maniphest links w.r.t. new "status" data format

Browse source 
Summary: 0 => imploded string of hotness.  Fixes T4689

Test Plan: for each spot i fixed, clicked link and it worked! (I did a grep for "/maniphest" to find these spots; 98% confident I got them all.)

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T4689

Differential Revision: https://secure.phabricator.com/D8626
This commit is contained in:
Bob Trahan 2014-03-28 12:59:09 -07:00
parent 1a36f24eb8
commit 8d41d9d8f8
4 changed files with 17 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/applications/home/controller/PhabricatorHomeMainController.php
View file

@ -148,7 +148,10 @@ final class PhabricatorHomeMainController
'Nothing appears to be critically broken right now.'); 'Nothing appears to be critically broken right now.');
} }
$href = '/maniphest/?statuses[]=0&priorities[]='.$unbreak_now.'#R'; $href = sprintf(
'/maniphest/?statuses[]=%s&priorities[]=%s#R',
implode(',', ManiphestTaskStatus::getOpenStatusConstants()),
$unbreak_now);
$title = pht('Unbreak Now!'); $title = pht('Unbreak Now!');
$panel = new AphrontPanelView(); $panel = new AphrontPanelView();
$panel->setHeader($this->renderSectionHeader($title, $href)); $panel->setHeader($this->renderSectionHeader($title, $href));
@ -193,8 +196,11 @@ final class PhabricatorHomeMainController
} }
$title = pht('Needs Triage'); $title = pht('Needs Triage');
$href = '/maniphest/?statuses[]=0&priorities[]='.$needs_triage. $href = sprintf(
'&userProjects[]='.$user->getPHID().'#R'; '/maniphest/?statuses[]=%s&priorities[]=%s&userProjects[]=%s#R',
implode(',', ManiphestTaskStatus::getOpenStatusConstants()),
$needs_triage,
$user->getPHID());
$panel = new AphrontPanelView(); $panel = new AphrontPanelView();
$panel->setHeader($this->renderSectionHeader($title, $href)); $panel->setHeader($this->renderSectionHeader($title, $href));
$panel->appendChild($this->buildTaskListView($tasks)); $panel->appendChild($this->buildTaskListView($tasks));

3
src/applications/maniphest/controller/ManiphestReportController.php
View file

@ -1,8 +1,5 @@
<?php <?php
/**
* @group maniphest
*/
final class ManiphestReportController extends ManiphestController { final class ManiphestReportController extends ManiphestController {
private $view; private $view;

5
src/applications/maniphest/event/ManiphestActionMenuEventListener.php
View file

@ -32,7 +32,10 @@ final class ManiphestActionMenuEventListener extends PhabricatorEventListener {
$user = $event->getValue('object'); $user = $event->getValue('object');
$phid = $user->getPHID(); $phid = $user->getPHID();
$view_uri = '/maniphest/?statuses[]=0&assigned='.$phid.'#R'; $view_uri = sprintf(
'/maniphest/?statuses[]=%s&assigned=%s#R',
implode(',', ManiphestTaskStatus::getOpenStatusConstants()),
$phid);
return id(new PhabricatorActionView()) return id(new PhabricatorActionView())
->setIcon('maniphest-dark') ->setIcon('maniphest-dark')

5
src/applications/project/controller/PhabricatorProjectProfileController.php
View file

@ -147,7 +147,10 @@ final class PhabricatorProjectProfileController
$task_list->setHandles($handles); $task_list->setHandles($handles);
$phid = $project->getPHID(); $phid = $project->getPHID();
$view_uri = '/maniphest/?statuses[]=0&allProjects[]='.$phid.'#R'; $view_uri = sprintf(
'/maniphest/?statuses[]=%s&allProjects[]=%s#R',
implode(',', ManiphestTaskStatus::getOpenStatusConstants()),
$phid);
$create_uri = '/maniphest/task/create/?projects='.$phid; $create_uri = '/maniphest/task/create/?projects='.$phid;
$icon = id(new PHUIIconView()) $icon = id(new PHUIIconView())
->setSpriteSheet(PHUIIconView::SPRITE_ICONS) ->setSpriteSheet(PHUIIconView::SPRITE_ICONS)