revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 00:42:41 +01:00
Code Issues Releases Wiki Activity

Macros - fix audio disabling not actually disabling audio

Browse source 
Summary: Fixes T5653.

Test Plan: made a macro with sound and it played. changed it to not play and it did not play. changed it back and it played once more.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T5653

Differential Revision: https://secure.phabricator.com/D10085
This commit is contained in:
Bob Trahan 2014-07-30 14:16:38 -07:00
parent bf10b7602b
commit 8d520fbae3
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/applications/macro/remarkup/PhabricatorRemarkupRuleImageMacro.php
View file

@ -124,7 +124,9 @@ final class PhabricatorRemarkupRuleImageMacro extends PhutilRemarkupRule {
$id = null;
$audio = idx($files, $macro->getAudioPHID());
if ($audio) {
$should_play = ($audio && $macro->getAudioBehavior() !=
PhabricatorFileImageMacro::AUDIO_BEHAVIOR_NONE);
if ($should_play) {
$id = celerity_generate_unique_node_id();
$loop = null;