revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-18 19:40:55 +01:00
Code Issues Releases Wiki Activity

Put the HeraldActionRecord table back on the shelf

Browse source 
Summary:
Fixes T8958. I renamed this class and table (in D13644), but the migration `20150606.mlist.1.php` needs to load records from the table before the table rename applies.

Put the table back and accept a tiny bit of cruft here to fix this problem. We can no-op the migration after a while.

I'll cherry-pick this to `stable`.

Test Plan: Applied migration. Created Herald rules. Reviewed existing Herald rules.

Reviewers: btrahan

Subscribers: epriestley

Maniphest Tasks: T8958

Differential Revision: https://secure.phabricator.com/D13736
This commit is contained in:
epriestley 2015-07-27 15:08:01 -07:00
parent 6802549355
commit 8d53f15115
2 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
resources/sql/autopatches/20150727.heraldaction.1.sql Normal file
View file

@ -0,0 +1,2 @@
RENAME TABLE {$NAMESPACE}_herald.herald_actionrecord
TO {$NAMESPACE}_herald.herald_action;

8
src/applications/herald/storage/HeraldActionRecord.php
View file

@ -7,6 +7,14 @@ final class HeraldActionRecord extends HeraldDAO {
protected $action; protected $action;
protected $target; protected $target;
public function getTableName() {
// TODO: This class was renamed, but we have a migration which affects the
// table prior to to the rename. For now, having cruft here is cleaner than
// having it in the migration. We could rename this table again and no-op
// the migration after some time. See T8958.
return 'herald_action';
}
protected function getConfiguration() { protected function getConfiguration() {
return array( return array(
self::CONFIG_SERIALIZATION => array( self::CONFIG_SERIALIZATION => array(