revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-19 05:12:41 +01:00
Code Issues Releases Wiki Activity

Render Remarkup poorly in Phame Feed stories

Browse source 
Summary: Seeing if this is the correct path, then will apply in Pholio, Ponder.

Test Plan: epriestley

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: joshuaspence, Korvin

Maniphest Tasks: T9825

Differential Revision: https://secure.phabricator.com/D14646
This commit is contained in:
Chad Little 2015-12-02 14:13:21 -08:00
parent dd82cd4922
commit 8d62ade70a
2 changed files with 12 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/applications/phame/storage/PhamePostTransaction.php
View file

@ -185,7 +185,7 @@ final class PhamePostTransaction
return parent::getTitleForFeed();
}
public function getBodyForFeed(PhabricatorFeedStory $story) {
public function getRemarkupBodyForFeed(PhabricatorFeedStory $story) {
$text = null;
switch ($this->getTransactionType()) {
case self::TYPE_TITLE:
@ -205,11 +205,7 @@ final class PhamePostTransaction
break;
}
if (strlen($text)) {
return PhabricatorMarkupEngine::summarize($text);
}
return parent::getBodyForFeed($story);
return $text;
}
public function getColor() {

10
src/applications/transactions/storage/PhabricatorApplicationTransaction.php
View file

@ -964,6 +964,12 @@ abstract class PhabricatorApplicationTransaction
}
public function getBodyForFeed(PhabricatorFeedStory $story) {
$remarkup = $this->getRemarkupBodyForFeed($story);
if ($remarkup !== null) {
$remarkup = PhabricatorMarkupEngine::summarize($remarkup);
return new PHUIRemarkupView($this->viewer, $remarkup);
}
$old = $this->getOldValue();
$new = $this->getNewValue();
@ -981,6 +987,10 @@ abstract class PhabricatorApplicationTransaction
return $body;
}
public function getRemarkupBodyForFeed(PhabricatorFeedStory $story) {
return null;
}
public function getActionStrength() {
if ($this->isInlineCommentTransaction()) {
return 0.25;