1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 23:02:42 +01:00

Make workboard sort-order inversions more clear by using "-1 * ..." instead of "(int)-(int)"

Summary: Depends on D20279. See D20269. Agreed that explicit `-1` is probably more clear.

Test Plan: Viewed boards in each sort/group order.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D20281
This commit is contained in:
epriestley 2019-03-12 13:05:16 -07:00
parent a400d82932
commit 8d74492875
3 changed files with 5 additions and 5 deletions

View file

@ -27,8 +27,8 @@ final class PhabricatorProjectColumnCreatedOrder
protected function newSortVectorForObject($object) {
return array(
-(int)$object->getDateCreated(),
-(int)$object->getID(),
-1 * (int)$object->getDateCreated(),
-1 * (int)$object->getID(),
);
}

View file

@ -42,8 +42,8 @@ final class PhabricatorProjectColumnPointsOrder
return array(
$overall_order,
-(double)$points,
-(int)$object->getID(),
-1.0 * (double)$points,
-1 * (int)$object->getID(),
);
}

View file

@ -39,7 +39,7 @@ final class PhabricatorProjectColumnPriorityOrder
private function newSortVectorForPriority($priority) {
return array(
-(int)$priority,
-1 * (int)$priority,
);
}