revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-30 08:28:20 +01:00
Code Issues Releases Wiki Activity

Always display Branch in revision

Browse source 
Summary:
I, as an author, sometimes forget branch associated with a revision.
Plus setting ##differential.show-host-field## makes a false sense of security
that branch will stay hidden so that I can name it
//finally_solve_this_crap_which_makes_no_sense//. But it is published in
Accepted and Request Changes e-mails anyway.

Test Plan: Display revision with disabled ##differential.show-host-field##.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D1602
This commit is contained in:
vrana 2012-02-12 01:36:05 -08:00
parent 5b8577db59
commit 8da4f981fb
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
conf/default.conf.php
View file

@ -597,8 +597,8 @@ return array(
'differential.field-selector' => 'DifferentialDefaultFieldSelector', 'differential.field-selector' => 'DifferentialDefaultFieldSelector',
// Differential can show "Host", "Path" and "Branch" fields on revisions, with // Differential can show "Host" and "Path" fields on revisions, with
// information about the machine, working directory and branch where the // information about the machine and working directory where the
// change came from. These fields are disabled by default because they may // change came from. These fields are disabled by default because they may
// occasionally have sensitive information; you can set this to true to // occasionally have sensitive information; you can set this to true to
// enable them. // enable them.

2
src/applications/differential/field/selector/default/DifferentialDefaultFieldSelector.php
View file

@ -42,13 +42,13 @@ final class DifferentialDefaultFieldSelector
array( array(
new DifferentialHostFieldSpecification(), new DifferentialHostFieldSpecification(),
new DifferentialPathFieldSpecification(), new DifferentialPathFieldSpecification(),
new DifferentialBranchFieldSpecification(),
)); ));
} }
$fields = array_merge( $fields = array_merge(
$fields, $fields,
array( array(
new DifferentialBranchFieldSpecification(),
new DifferentialArcanistProjectFieldSpecification(), new DifferentialArcanistProjectFieldSpecification(),
new DifferentialApplyPatchFieldSpecification(), new DifferentialApplyPatchFieldSpecification(),
new DifferentialRevisionIDFieldSpecification(), new DifferentialRevisionIDFieldSpecification(),