revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 06:42:42 +01:00
Code Issues Releases Wiki Activity

Remove TERM=dumb, which is causing difficult-to-reproduce hangs

Browse source 
Summary:
Ref T7119. Three users have now reported that this causes their systems to hang, so it's looking like the cure is worse than the disease.

Revert this until we can eventually reproduce and understand the hang.

Test Plan: Users running into issues have reported that this resolves things.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7119

Differential Revision: https://secure.phabricator.com/D11644
This commit is contained in:
epriestley 2015-02-03 09:54:02 -08:00
parent d7b9b8b2ce
commit 8e2f054fe4
1 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
scripts/repository/commit_hook.php
View file

@ -1,14 +1,13 @@
#!/usr/bin/env TERM=dumb php #!/usr/bin/env php
<?php <?php
// NOTE: Note that we're specifying TERM=dumb above when invoking the PHP // NOTE: This script will sometimes emit a warning like this on startup:
// interpreter. This suppresses an error which looks like this:
// //
// No entry for terminal type "unknown"; // No entry for terminal type "unknown";
// using dumb terminal settings. // using dumb terminal settings.
// //
// This arises from somewhere in the PHP startup machinery if TERM is not // This can be fixed by adding "TERM=dumb" to the shebang line, but doing so
// set to a recognized value. // causes some systems to hang mysteriously. See T7119.
// Commit hooks execute in an unusual context where the environment may be // Commit hooks execute in an unusual context where the environment may be
// unavailable, particularly in SVN. The first parameter to this script is // unavailable, particularly in SVN. The first parameter to this script is