Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery"

Summary: Ref T13682. Many subclasses of "CursorPagedPolicyAwareQuery" have the same implementation of "loadPage()", and this is a sensible default behavior.

Test Plan: Examined changes to verify that all removed methods have the same behavior.

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T13682

Differential Revision: https://secure.phabricator.com/D21838

src/applications/almanac/query/AlmanacBindingQuery.php

@@ -44,10 +44,6 @@ final class AlmanacBindingQuery
     return new AlmanacBinding();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function willFilterPage(array $bindings) {
     $service_phids = mpull($bindings, 'getServicePHID');
     $device_phids = mpull($bindings, 'getDevicePHID');

src/applications/almanac/query/AlmanacDeviceQuery.php

@@ -56,10 +56,6 @@ final class AlmanacDeviceQuery
     return new AlmanacDevice();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
     $where = parent::buildWhereClauseParts($conn);
 

src/applications/almanac/query/AlmanacInterfaceQuery.php

@@ -38,10 +38,6 @@ final class AlmanacInterfaceQuery
     return new AlmanacInterface();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function willFilterPage(array $interfaces) {
     $network_phids = mpull($interfaces, 'getNetworkPHID');
     $device_phids = mpull($interfaces, 'getDevicePHID');

src/applications/almanac/query/AlmanacNamespaceQuery.php

@@ -32,10 +32,6 @@ final class AlmanacNamespaceQuery
     return new AlmanacNamespace();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
     $where = parent::buildWhereClauseParts($conn);
 

src/applications/almanac/query/AlmanacNetworkQuery.php

@@ -32,10 +32,6 @@ final class AlmanacNetworkQuery
       $ngrams);
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
     $where = parent::buildWhereClauseParts($conn);
 

src/applications/almanac/query/AlmanacPropertyQuery.php

@@ -33,10 +33,6 @@ final class AlmanacPropertyQuery
     return new AlmanacProperty();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function willFilterPage(array $properties) {
     $object_phids = mpull($properties, 'getObjectPHID');
 

src/applications/almanac/query/AlmanacServiceQuery.php

@@ -69,10 +69,6 @@ final class AlmanacServiceQuery
     return new AlmanacService();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function buildJoinClauseParts(AphrontDatabaseConnection $conn) {
     $joins = parent::buildJoinClauseParts($conn);
 

src/applications/auth/query/PhabricatorAuthChallengeQuery.php

@@ -40,10 +40,6 @@ final class PhabricatorAuthChallengeQuery
     return new PhabricatorAuthChallenge();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
     $where = parent::buildWhereClauseParts($conn);
 

src/applications/auth/query/PhabricatorAuthContactNumberQuery.php

@@ -44,10 +44,6 @@ final class PhabricatorAuthContactNumberQuery
     return new PhabricatorAuthContactNumber();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
     $where = parent::buildWhereClauseParts($conn);
 

src/applications/auth/query/PhabricatorAuthFactorConfigQuery.php

@@ -38,10 +38,6 @@ final class PhabricatorAuthFactorConfigQuery
     return new PhabricatorAuthFactorConfig();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
     $where = parent::buildWhereClauseParts($conn);
 

src/applications/auth/query/PhabricatorAuthFactorProviderQuery.php

@@ -32,10 +32,6 @@ final class PhabricatorAuthFactorProviderQuery
     return new PhabricatorAuthFactorProvider();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
     $where = parent::buildWhereClauseParts($conn);
 

src/applications/auth/query/PhabricatorAuthMessageQuery.php

@@ -26,10 +26,6 @@ final class PhabricatorAuthMessageQuery
     return new PhabricatorAuthMessage();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
     $where = parent::buildWhereClauseParts($conn);
 

src/applications/auth/query/PhabricatorAuthPasswordQuery.php

@@ -38,10 +38,6 @@ final class PhabricatorAuthPasswordQuery
     return new PhabricatorAuthPassword();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
     $where = parent::buildWhereClauseParts($conn);
 

src/applications/auth/query/PhabricatorAuthProviderConfigQuery.php

@@ -32,10 +32,6 @@ final class PhabricatorAuthProviderConfigQuery
     return new PhabricatorAuthProviderConfig();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
     $where = parent::buildWhereClauseParts($conn);
 

src/applications/auth/query/PhabricatorAuthSSHKeyQuery.php

@@ -47,10 +47,6 @@ final class PhabricatorAuthSSHKeyQuery
     return new PhabricatorAuthSSHKey();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function willFilterPage(array $keys) {
     $object_phids = mpull($keys, 'getObjectPHID');
 

src/applications/auth/query/PhabricatorAuthSessionQuery.php

@@ -38,10 +38,6 @@ final class PhabricatorAuthSessionQuery
     return new PhabricatorAuthSession();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function willFilterPage(array $sessions) {
     $identity_phids = mpull($sessions, 'getUserPHID');
 

src/applications/auth/query/PhabricatorAuthTemporaryTokenQuery.php

@@ -44,10 +44,6 @@ final class PhabricatorAuthTemporaryTokenQuery
     return new PhabricatorAuthTemporaryToken();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
     $where = parent::buildWhereClauseParts($conn);
 

src/applications/auth/query/PhabricatorExternalAccountIdentifierQuery.php

@@ -38,10 +38,6 @@ final class PhabricatorExternalAccountIdentifierQuery
     return new PhabricatorExternalAccountIdentifier();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
     $where = parent::buildWhereClauseParts($conn);
 

src/applications/auth/query/PhabricatorExternalAccountQuery.php

@@ -66,10 +66,6 @@ final class PhabricatorExternalAccountQuery
     return new PhabricatorExternalAccount();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function willFilterPage(array $accounts) {
     $viewer = $this->getViewer();
 

src/applications/badges/query/PhabricatorBadgesAwardQuery.php

@@ -57,10 +57,6 @@ final class PhabricatorBadgesAwardQuery
     return (bool)$this->badgeStatuses;
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   public function newResultObject() {
     return new PhabricatorBadgesAward();
   }

src/applications/badges/query/PhabricatorBadgesQuery.php

@@ -34,10 +34,6 @@ final class PhabricatorBadgesQuery
       $ngrams);
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function getPrimaryTableAlias() {
     return 'badges';
   }

src/applications/calendar/query/PhabricatorCalendarExportQuery.php

@@ -38,10 +38,6 @@ final class PhabricatorCalendarExportQuery
     return new PhabricatorCalendarExport();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
     $where = parent::buildWhereClauseParts($conn);
 

src/applications/calendar/query/PhabricatorCalendarExternalInviteeQuery.php

@@ -26,10 +26,6 @@ final class PhabricatorCalendarExternalInviteeQuery
     return new PhabricatorCalendarExternalInvitee();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
     $where = parent::buildWhereClauseParts($conn);
 

src/applications/calendar/query/PhabricatorCalendarImportLogQuery.php

@@ -26,10 +26,6 @@ final class PhabricatorCalendarImportLogQuery
     return new PhabricatorCalendarImportLog();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
     $where = parent::buildWhereClauseParts($conn);
 

src/applications/calendar/query/PhabricatorCalendarImportQuery.php

@@ -32,10 +32,6 @@ final class PhabricatorCalendarImportQuery
     return new PhabricatorCalendarImport();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
     $where = parent::buildWhereClauseParts($conn);
 

src/applications/conduit/query/PhabricatorConduitLogQuery.php

@@ -40,10 +40,6 @@ final class PhabricatorConduitLogQuery
     return new PhabricatorConduitMethodCallLog();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
     $where = parent::buildWhereClauseParts($conn);
 

src/applications/conduit/query/PhabricatorConduitTokenQuery.php

@@ -38,10 +38,6 @@ final class PhabricatorConduitTokenQuery
     return new PhabricatorConduitToken();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
     $where = parent::buildWhereClauseParts($conn);
 

src/applications/countdown/query/PhabricatorCountdownQuery.php

@@ -28,10 +28,6 @@ final class PhabricatorCountdownQuery
     return $this;
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   public function newResultObject() {
     return new PhabricatorCountdown();
   }

src/applications/dashboard/query/PhabricatorDashboardPanelQuery.php

@@ -34,10 +34,6 @@ final class PhabricatorDashboardPanelQuery
     return $this;
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   public function newResultObject() {
     // TODO: If we don't do this, SearchEngine explodes when trying to
     // enumerate custom fields. For now, just give the panel a default panel

src/applications/dashboard/query/PhabricatorDashboardPortalQuery.php

@@ -26,10 +26,6 @@ final class PhabricatorDashboardPortalQuery
     return new PhabricatorDashboardPortal();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
     $where = parent::buildWhereClauseParts($conn);
 

src/applications/dashboard/query/PhabricatorDashboardQuery.php

@@ -34,10 +34,6 @@ final class PhabricatorDashboardQuery
     return $this;
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   public function newResultObject() {
     return new PhabricatorDashboard();
   }

src/applications/differential/query/DifferentialChangesetQuery.php

@@ -58,10 +58,6 @@ final class DifferentialChangesetQuery
     return new DifferentialChangeset();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function willFilterPage(array $changesets) {
     // First, attach all the diffs we already have. We can just do this
     // directly without worrying about querying for them. When we don't have

src/applications/differential/query/DifferentialDiffQuery.php

@@ -57,10 +57,6 @@ final class DifferentialDiffQuery
     return new DifferentialDiff();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function willFilterPage(array $diffs) {
     $revision_ids = array_filter(mpull($diffs, 'getRevisionID'));
 

src/applications/differential/query/DifferentialHunkQuery.php

@@ -34,10 +34,6 @@ final class DifferentialHunkQuery
     return new DifferentialHunk();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function willFilterPage(array $hunks) {
     $changesets = mpull($this->changesets, null, 'getID');
     foreach ($hunks as $key => $hunk) {

src/applications/differential/query/DifferentialViewStateQuery.php

@@ -26,10 +26,6 @@ final class DifferentialViewStateQuery
     return new DifferentialViewState();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
     $where = parent::buildWhereClauseParts($conn);
 

src/applications/diffusion/query/DiffusionCommitHintQuery.php

@@ -56,10 +56,6 @@ final class DiffusionCommitHintQuery
     $this->commitMap = array();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
     $where = parent::buildWhereClauseParts($conn);
 

src/applications/doorkeeper/query/DoorkeeperExternalObjectQuery.php

@@ -20,10 +20,6 @@ final class DoorkeeperExternalObjectQuery
     return new DoorkeeperExternalObject();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
     $where = parent::buildWhereClauseParts($conn);
 

src/applications/drydock/query/DrydockAuthorizationQuery.php

@@ -72,10 +72,6 @@ final class DrydockAuthorizationQuery extends DrydockQuery {
     return new DrydockAuthorization();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function willFilterPage(array $authorizations) {
     $blueprint_phids = mpull($authorizations, 'getBlueprintPHID');
     if ($blueprint_phids) {

src/applications/drydock/query/DrydockBlueprintQuery.php

@@ -95,10 +95,6 @@ final class DrydockBlueprintQuery extends DrydockQuery {
     return 'blueprint';
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function willExecute() {
     if ($this->identifiers) {
       $this->identifierMap = array();

src/applications/drydock/query/DrydockCommandQuery.php

@@ -25,10 +25,6 @@ final class DrydockCommandQuery extends DrydockQuery {
     return new DrydockCommand();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function willFilterPage(array $commands) {
     $target_phids = mpull($commands, 'getTargetPHID');
 

src/applications/drydock/query/DrydockLeaseQuery.php

@@ -57,10 +57,6 @@ final class DrydockLeaseQuery extends DrydockQuery {
     return new DrydockLease();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function willFilterPage(array $leases) {
     $resource_phids = array_filter(mpull($leases, 'getResourcePHID'));
     if ($resource_phids) {

src/applications/drydock/query/DrydockLogQuery.php

@@ -37,10 +37,6 @@ final class DrydockLogQuery extends DrydockQuery {
     return new DrydockLog();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function didFilterPage(array $logs) {
     $blueprint_phids = array_filter(mpull($logs, 'getBlueprintPHID'));
     if ($blueprint_phids) {

src/applications/drydock/query/DrydockRepositoryOperationQuery.php

@@ -55,10 +55,6 @@ final class DrydockRepositoryOperationQuery extends DrydockQuery {
     return new DrydockRepositoryOperation();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function willFilterPage(array $operations) {
     $implementations = DrydockRepositoryOperationType::getAllOperationTypes();
 

src/applications/drydock/query/DrydockResourceQuery.php

@@ -49,10 +49,6 @@ final class DrydockResourceQuery extends DrydockQuery {
     return new DrydockResource();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function willFilterPage(array $resources) {
     $blueprint_phids = mpull($resources, 'getBlueprintPHID');
 

src/applications/files/query/PhabricatorFileAttachmentQuery.php

@@ -32,10 +32,6 @@ final class PhabricatorFileAttachmentQuery
     return new PhabricatorFileAttachment();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
     $where = parent::buildWhereClauseParts($conn);
 

src/applications/fund/query/FundInitiativeQuery.php

@@ -32,10 +32,6 @@ final class FundInitiativeQuery
     return new FundInitiative();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
     $where = parent::buildWhereClauseParts($conn);
 

src/applications/harbormaster/query/HarbormasterBuildArtifactQuery.php

@@ -40,10 +40,6 @@ final class HarbormasterBuildArtifactQuery
     return new HarbormasterBuildArtifact();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function willFilterPage(array $page) {
     $build_targets = array();
 

src/applications/harbormaster/query/HarbormasterBuildLogQuery.php

@@ -27,10 +27,6 @@ final class HarbormasterBuildLogQuery
     return new HarbormasterBuildLog();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function willFilterPage(array $page) {
     $build_targets = array();
 

src/applications/harbormaster/query/HarbormasterBuildMessageQuery.php

@@ -26,10 +26,6 @@ final class HarbormasterBuildMessageQuery
     return new HarbormasterBuildMessage();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function willFilterPage(array $page) {
     $receiver_phids = array_filter(mpull($page, 'getReceiverPHID'));
     if ($receiver_phids) {

src/applications/harbormaster/query/HarbormasterBuildPlanQuery.php

@@ -50,10 +50,6 @@ final class HarbormasterBuildPlanQuery
     return new HarbormasterBuildPlan();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function didFilterPage(array $page) {
     if ($this->needBuildSteps) {
       $plan_phids = mpull($page, 'getPHID');

src/applications/harbormaster/query/HarbormasterBuildQuery.php

@@ -56,10 +56,6 @@ final class HarbormasterBuildQuery
     return new HarbormasterBuild();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function willFilterPage(array $page) {
     $buildables = array();
 

src/applications/harbormaster/query/HarbormasterBuildStepQuery.php

@@ -26,10 +26,6 @@ final class HarbormasterBuildStepQuery
     return new HarbormasterBuildStep();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
     $where = parent::buildWhereClauseParts($conn);
 

src/applications/harbormaster/query/HarbormasterBuildTargetQuery.php

@@ -69,10 +69,6 @@ final class HarbormasterBuildTargetQuery
     return new HarbormasterBuildTarget();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
     $where = parent::buildWhereClauseParts($conn);
 

src/applications/harbormaster/query/HarbormasterBuildUnitMessageQuery.php

@@ -26,10 +26,6 @@ final class HarbormasterBuildUnitMessageQuery
     return new HarbormasterBuildUnitMessage();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
     $where = parent::buildWhereClauseParts($conn);
 

src/applications/harbormaster/query/HarbormasterBuildableQuery.php

@@ -63,10 +63,6 @@ final class HarbormasterBuildableQuery
     return new HarbormasterBuildable();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function willFilterPage(array $page) {
     $buildables = array();
 

src/applications/herald/query/HeraldRuleQuery.php

@@ -86,10 +86,6 @@ final class HeraldRuleQuery extends PhabricatorCursorPagedPolicyAwareQuery {
     return new HeraldRule();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function willFilterPage(array $rules) {
     $rule_ids = mpull($rules, 'getID');
 

src/applications/herald/query/HeraldWebhookQuery.php

@@ -26,10 +26,6 @@ final class HeraldWebhookQuery
     return new HeraldWebhook();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
     $where = parent::buildWhereClauseParts($conn);
 

src/applications/herald/query/HeraldWebhookRequestQuery.php

@@ -29,10 +29,6 @@ final class HeraldWebhookRequestQuery
     return new HeraldWebhookRequest();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   public function withLastRequestEpochBetween($epoch_min, $epoch_max) {
     $this->lastRequestEpochMin = $epoch_min;
     $this->lastRequestEpochMax = $epoch_max;

src/applications/legalpad/query/LegalpadDocumentQuery.php

@@ -81,10 +81,6 @@ final class LegalpadDocumentQuery
     return new LegalpadDocument();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function willFilterPage(array $documents) {
     if ($this->needDocumentBodies) {
       $documents = $this->loadDocumentBodies($documents);

src/applications/macro/query/PhabricatorMacroQuery.php

@@ -100,10 +100,6 @@ final class PhabricatorMacroQuery
     return new PhabricatorFileImageMacro();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage(new PhabricatorFileImageMacro());
-  }
-
   protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
     $where = parent::buildWhereClauseParts($conn);
 

src/applications/metamta/query/PhabricatorMetaMTAMailPropertiesQuery.php

@@ -20,10 +20,6 @@ final class PhabricatorMetaMTAMailPropertiesQuery
     return new PhabricatorMetaMTAMailProperties();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
     $where = parent::buildWhereClauseParts($conn);
 

src/applications/metamta/query/PhabricatorMetaMTAMailQuery.php

@@ -36,10 +36,6 @@ final class PhabricatorMetaMTAMailQuery
     return $this;
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
     $where = parent::buildWhereClauseParts($conn);
 

src/applications/nuance/query/NuanceImportCursorDataQuery.php

@@ -26,10 +26,6 @@ final class NuanceImportCursorDataQuery
     return new NuanceImportCursorData();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
     $where = parent::buildWhereClauseParts($conn);
 

src/applications/nuance/query/NuanceItemCommandQuery.php

@@ -26,10 +26,6 @@ final class NuanceItemCommandQuery
     return new NuanceItemCommand();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
     $where = parent::buildWhereClauseParts($conn);
 

src/applications/nuance/query/NuanceItemQuery.php

@@ -56,10 +56,6 @@ final class NuanceItemQuery
     return new NuanceItem();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function willFilterPage(array $items) {
     $viewer = $this->getViewer();
     $source_phids = mpull($items, 'getSourcePHID');

src/applications/nuance/query/NuanceQueueQuery.php

@@ -20,10 +20,6 @@ final class NuanceQueueQuery
     return new NuanceQueue();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
     $where = parent::buildWhereClauseParts($conn);
 

src/applications/nuance/query/NuanceSourceQuery.php

@@ -48,10 +48,6 @@ final class NuanceSourceQuery
     return 'source';
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function willFilterPage(array $sources) {
     $all_types = NuanceSourceDefinition::getAllDefinitions();
 

src/applications/oauthserver/query/PhabricatorOAuthClientAuthorizationQuery.php

@@ -26,10 +26,6 @@ final class PhabricatorOAuthClientAuthorizationQuery
     return new PhabricatorOAuthClientAuthorization();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function willFilterPage(array $authorizations) {
     $client_phids = mpull($authorizations, 'getClientPHID');
 

src/applications/owners/query/PhabricatorOwnersPackageQuery.php

@@ -102,10 +102,6 @@ final class PhabricatorOwnersPackageQuery
     $this->controlResults = array();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function willFilterPage(array $packages) {
     $package_ids = mpull($packages, 'getID');
 

src/applications/packages/query/PhabricatorPackagesPackageQuery.php

@@ -44,10 +44,6 @@ final class PhabricatorPackagesPackageQuery
     return new PhabricatorPackagesPackage();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
     $where = parent::buildWhereClauseParts($conn);
 

src/applications/packages/query/PhabricatorPackagesPublisherQuery.php

@@ -32,10 +32,6 @@ final class PhabricatorPackagesPublisherQuery
     return new PhabricatorPackagesPublisher();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
     $where = parent::buildWhereClauseParts($conn);
 

src/applications/packages/query/PhabricatorPackagesVersionQuery.php

@@ -44,10 +44,6 @@ final class PhabricatorPackagesVersionQuery
     return new PhabricatorPackagesVersion();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
     $where = parent::buildWhereClauseParts($conn);
 

src/applications/passphrase/query/PassphraseCredentialQuery.php

@@ -57,10 +57,6 @@ final class PassphraseCredentialQuery
     return new PassphraseCredential();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function willFilterPage(array $page) {
     if ($this->needSecrets) {
       $secret_ids = mpull($page, 'getSecretID');

src/applications/paste/query/PhabricatorPasteQuery.php

@@ -84,10 +84,6 @@ final class PhabricatorPasteQuery
     return new PhabricatorPaste();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage(new PhabricatorPaste());
-  }
-
   protected function didFilterPage(array $pastes) {
     if ($this->needRawContent) {
       $pastes = $this->loadRawContent($pastes);

src/applications/people/query/PhabricatorPeopleLogQuery.php

@@ -58,10 +58,6 @@ final class PhabricatorPeopleLogQuery
     return new PhabricatorUserLog();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
     $where = parent::buildWhereClauseParts($conn);
 

src/applications/people/query/PhabricatorPeopleQuery.php

@@ -162,10 +162,6 @@ final class PhabricatorPeopleQuery
     return new PhabricatorUser();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function didFilterPage(array $users) {
     if ($this->needProfile) {
       $user_list = mpull($users, null, 'getPHID');

src/applications/people/query/PhabricatorPeopleUserEmailQuery.php

@@ -20,10 +20,6 @@ final class PhabricatorPeopleUserEmailQuery
     return new PhabricatorUserEmail();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function getPrimaryTableAlias() {
     return 'email';
   }

src/applications/phame/query/PhameBlogQuery.php

@@ -45,10 +45,6 @@ final class PhameBlogQuery extends PhabricatorCursorPagedPolicyAwareQuery {
     return new PhameBlog();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
     $where = parent::buildWhereClauseParts($conn);
 

src/applications/phame/query/PhamePostQuery.php

@@ -50,10 +50,6 @@ final class PhamePostQuery extends PhabricatorCursorPagedPolicyAwareQuery {
     return new PhamePost();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function willFilterPage(array $posts) {
     // We require blogs to do visibility checks, so load them unconditionally.
     $blog_phids = mpull($posts, 'getBlogPHID');

src/applications/pholio/query/PholioImageQuery.php

@@ -44,10 +44,6 @@ final class PholioImageQuery
     return new PholioImage();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
     $where = parent::buildWhereClauseParts($conn);
 

src/applications/phortune/query/PhortuneAccountEmailQuery.php

@@ -38,10 +38,6 @@ final class PhortuneAccountEmailQuery
     return new PhortuneAccountEmail();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function willFilterPage(array $addresses) {
     $accounts = id(new PhortuneAccountQuery())
       ->setViewer($this->getViewer())

src/applications/phortune/query/PhortuneAccountQuery.php

@@ -46,10 +46,6 @@ final class PhortuneAccountQuery
     return new PhortuneAccount();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function willFilterPage(array $accounts) {
     $query = id(new PhabricatorEdgeQuery())
       ->withSourcePHIDs(mpull($accounts, 'getPHID'))

src/applications/phortune/query/PhortuneMerchantQuery.php

@@ -32,10 +32,6 @@ final class PhortuneMerchantQuery
     return new PhortuneMerchant();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function willFilterPage(array $merchants) {
     $query = id(new PhabricatorEdgeQuery())
       ->withSourcePHIDs(mpull($merchants, 'getPHID'))

src/applications/phortune/query/PhortunePaymentMethodQuery.php

@@ -38,10 +38,6 @@ final class PhortunePaymentMethodQuery
     return new PhortunePaymentMethod();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function willFilterPage(array $methods) {
     $accounts = id(new PhortuneAccountQuery())
       ->setViewer($this->getViewer())

src/applications/phortune/query/PhortuneSubscriptionQuery.php

@@ -51,10 +51,6 @@ final class PhortuneSubscriptionQuery
     return new PhortuneSubscription();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function willFilterPage(array $subscriptions) {
     $accounts = id(new PhortuneAccountQuery())
       ->setViewer($this->getViewer())

src/applications/phriction/query/PhrictionContentQuery.php

@@ -32,10 +32,6 @@ final class PhrictionContentQuery
     return new PhrictionContent();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
     $where = parent::buildWhereClauseParts($conn);
 

src/applications/phriction/query/PhrictionDocumentQuery.php

@@ -62,10 +62,6 @@ final class PhrictionDocumentQuery
     return $this;
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   public function newResultObject() {
     return new PhrictionDocument();
   }

src/applications/phurl/query/PhabricatorPhurlURLQuery.php

@@ -50,10 +50,6 @@ final class PhabricatorPhurlURLQuery
     return $this;
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
     $where = parent::buildWhereClauseParts($conn);
 

src/applications/ponder/query/PonderAnswerQuery.php

@@ -59,10 +59,6 @@ final class PonderAnswerQuery
     return new PonderAnswer();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage(new PonderAnswer());
-  }
-
   protected function willFilterPage(array $answers) {
     $questions = id(new PonderQuestionQuery())
       ->setViewer($this->getViewer())

src/applications/ponder/query/PonderQuestionQuery.php

@@ -86,10 +86,6 @@ final class PonderQuestionQuery
     return new PonderQuestion();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage(new PonderQuestion());
-  }
-
   protected function willFilterPage(array $questions) {
 
     $phids = mpull($questions, 'getPHID');

src/applications/project/query/PhabricatorProjectColumnPositionQuery.php

@@ -32,10 +32,6 @@ final class PhabricatorProjectColumnPositionQuery
     return new PhabricatorProjectColumnPosition();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
     $where = array();
 

src/applications/project/query/PhabricatorProjectColumnQuery.php

@@ -56,10 +56,6 @@ final class PhabricatorProjectColumnQuery
     return new PhabricatorProjectColumn();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function willFilterPage(array $page) {
     $projects = array();
 

src/applications/project/query/PhabricatorProjectQuery.php

@@ -236,10 +236,6 @@ final class PhabricatorProjectQuery
     }
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function willFilterPage(array $projects) {
     $ancestor_paths = array();
     foreach ($projects as $project) {

src/applications/project/query/PhabricatorProjectTriggerQuery.php

@@ -35,10 +35,6 @@ final class PhabricatorProjectTriggerQuery
     return new PhabricatorProjectTrigger();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
     $where = parent::buildWhereClauseParts($conn);
 

src/applications/repository/query/PhabricatorRepositoryGitLFSRefQuery.php

@@ -26,10 +26,6 @@ final class PhabricatorRepositoryGitLFSRefQuery
     return new PhabricatorRepositoryGitLFSRef();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
     $where = parent::buildWhereClauseParts($conn);
 

src/applications/repository/query/PhabricatorRepositoryIdentityQuery.php

@@ -66,10 +66,6 @@ final class PhabricatorRepositoryIdentityQuery
      return 'identity';
    }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
     $where = parent::buildWhereClauseParts($conn);
 

src/applications/repository/query/PhabricatorRepositoryPullEventQuery.php

@@ -40,10 +40,6 @@ final class PhabricatorRepositoryPullEventQuery
     return new PhabricatorRepositoryPullEvent();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function willFilterPage(array $events) {
     // If a pull targets an invalid repository or fails before authenticating,
     // it may not have an associated repository.

src/applications/repository/query/PhabricatorRepositoryPushEventQuery.php

@@ -38,10 +38,6 @@ final class PhabricatorRepositoryPushEventQuery
     return new PhabricatorRepositoryPushEvent();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function willFilterPage(array $events) {
     $repository_phids = mpull($events, 'getRepositoryPHID');
     $repositories = id(new PhabricatorRepositoryQuery())

src/applications/repository/query/PhabricatorRepositoryPushLogQuery.php

@@ -64,10 +64,6 @@ final class PhabricatorRepositoryPushLogQuery
     return new PhabricatorRepositoryPushLog();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function willFilterPage(array $logs) {
     $event_phids = mpull($logs, 'getPushEventPHID');
     $events = id(new PhabricatorObjectQuery())

src/applications/repository/query/PhabricatorRepositoryRefCursorQuery.php

@@ -50,10 +50,6 @@ final class PhabricatorRepositoryRefCursorQuery
     return new PhabricatorRepositoryRefCursor();
   }
 
-  protected function loadPage() {
-    return $this->loadStandardPage($this->newResultObject());
-  }
-
   protected function willFilterPage(array $refs) {
     $repository_phids = mpull($refs, 'getRepositoryPHID');