mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-10 00:42:41 +01:00
Fix PHP 8.1 "strlen(null)" exception which blocks rendering a config page
Summary: `strlen()` was used in Phabricator to check if a generic value is a non-empty string. This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement. Note: this may highlight other absurd input values that might be worth correcting instead of just ignoring. If phutil_nonempty_string() throws an exception in your instance, report it to Phorge to evaluate and fix that specific corner case. Closes T15336 Test Plan: Applied this change and `/config/edit/load-libraries/` correctly rendered in web browser. Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Maniphest Tasks: T15336 Differential Revision: https://we.phorge.it/D25181
This commit is contained in:
parent
953726d71b
commit
8eaa7c1ccf
1 changed files with 12 additions and 1 deletions
|
@ -156,11 +156,22 @@ final class PhabricatorConfigOption
|
|||
return $this->summary;
|
||||
}
|
||||
|
||||
/**
|
||||
* Set the human Description of this Config
|
||||
*
|
||||
* @param string|null $description Description as raw Remarkup
|
||||
* @return self
|
||||
*/
|
||||
public function setDescription($description) {
|
||||
$this->description = $description;
|
||||
return $this;
|
||||
}
|
||||
|
||||
/**
|
||||
* Get the human Description of this Config
|
||||
*
|
||||
* @return string|null Description as raw Remarkup
|
||||
*/
|
||||
public function getDescription() {
|
||||
return $this->description;
|
||||
}
|
||||
|
@ -205,7 +216,7 @@ final class PhabricatorConfigOption
|
|||
|
||||
public function newDescriptionRemarkupView(PhabricatorUser $viewer) {
|
||||
$description = $this->getDescription();
|
||||
if (!strlen($description)) {
|
||||
if (!phutil_nonempty_string($description)) {
|
||||
return null;
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue