revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-19 05:12:41 +01:00
Code Issues Releases Wiki Activity

Use a password input for HTTP Basic Auth in repositories

Browse source 
Summary: See D902. As @abdul notes, a password input is probably more
appropraite here.

Test Plan: Mashed stuff into it, got bullets instead of text.

Reviewers: abdul, jungejason, nh, tuomaspelkonen, aran

Reviewed By: nh

CC: aran, nh

Differential Revision: 913
This commit is contained in:
epriestley 2011-09-08 14:34:16 -07:00
parent 0366936d4c
commit 8f772929ac
2 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/repository/controller/edit/PhabricatorRepositoryEditController.php
View file

@ -453,7 +453,7 @@ class PhabricatorRepositoryEditController
->setLabel('HTTP Basic Login') ->setLabel('HTTP Basic Login')
->setValue($repository->getDetail('http-login'))) ->setValue($repository->getDetail('http-login')))
->appendChild( ->appendChild(
id(new AphrontFormTextControl()) id(new AphrontFormPasswordControl())
->setName('http-pass') ->setName('http-pass')
->setLabel('HTTP Basic Password') ->setLabel('HTTP Basic Password')
->setValue($repository->getDetail('http-pass'))); ->setValue($repository->getDetail('http-pass')));

1
src/applications/repository/controller/edit/__init__.php
View file

@ -17,6 +17,7 @@ phutil_require_module('phabricator', 'applications/repository/storage/repository
phutil_require_module('phabricator', 'infrastructure/env'); phutil_require_module('phabricator', 'infrastructure/env');
phutil_require_module('phabricator', 'view/control/table'); phutil_require_module('phabricator', 'view/control/table');
phutil_require_module('phabricator', 'view/form/base'); phutil_require_module('phabricator', 'view/form/base');
phutil_require_module('phabricator', 'view/form/control/password');
phutil_require_module('phabricator', 'view/form/control/select'); phutil_require_module('phabricator', 'view/form/control/select');
phutil_require_module('phabricator', 'view/form/control/static'); phutil_require_module('phabricator', 'view/form/control/static');
phutil_require_module('phabricator', 'view/form/control/submit'); phutil_require_module('phabricator', 'view/form/control/submit');