From 8fc5817f65e851c871770cbaf2ba8bb2996e190b Mon Sep 17 00:00:00 2001
From: vrana <jakubv@fb.com>
Date: Thu, 16 Aug 2012 23:35:50 -0700
Subject: [PATCH] Display draft reviews in revision lists

Summary:
We have /differential/filter/drafts/ but nobody knows about it.
This diff displays the draft only if there is no flag to not waste space.

Test Plan: /differential/filter/revisions/

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin, alanh

Differential Revision: https://secure.phabricator.com/D3324
---
 .../view/DifferentialRevisionListView.php     |  22 ++++++++++++++++++
 .../image/icon/fatcow/page_white_edit.png     | Bin 0 -> 719 bytes
 2 files changed, 22 insertions(+)
 create mode 100644 webroot/rsrc/image/icon/fatcow/page_white_edit.png

diff --git a/src/applications/differential/view/DifferentialRevisionListView.php b/src/applications/differential/view/DifferentialRevisionListView.php
index e5015b0bee..2c73686fa2 100644
--- a/src/applications/differential/view/DifferentialRevisionListView.php
+++ b/src/applications/differential/view/DifferentialRevisionListView.php
@@ -23,6 +23,7 @@ final class DifferentialRevisionListView extends AphrontView {
 
   private $revisions;
   private $flags = array();
+  private $drafts = array();
   private $handles;
   private $user;
   private $fields;
@@ -84,6 +85,11 @@ final class DifferentialRevisionListView extends AphrontView {
       ->withObjectPHIDs(mpull($this->revisions, 'getPHID'))
       ->execute();
 
+    $this->drafts = id(new DifferentialRevisionQuery())
+      ->withIDs(mpull($this->revisions, 'getID'))
+      ->withDraftRepliesByAuthors(array($user->getPHID()))
+      ->execute();
+
     return $this;
   }
 
@@ -135,7 +141,23 @@ final class DifferentialRevisionListView extends AphrontView {
             'class' => 'phabricator-flag-icon '.$class,
           ),
           '');
+
+      } else if (array_key_exists($revision->getID(), $this->drafts)) {
+        $src = '/rsrc/image/icon/fatcow/page_white_edit.png';
+        $flag =
+          '<a href="/D'.$revision->getID().'#comment-preview">'.
+            phutil_render_tag(
+              'img',
+              array(
+                'src' => celerity_get_resource_uri($src),
+                'width' => 16,
+                'height' => 16,
+                'alt' => 'Draft',
+                'title' => 'Draft Comment',
+              )).
+            '</a>';
       }
+
       $row = array($flag);
 
       $modified = $revision->getDateModified();
diff --git a/webroot/rsrc/image/icon/fatcow/page_white_edit.png b/webroot/rsrc/image/icon/fatcow/page_white_edit.png
new file mode 100644
index 0000000000000000000000000000000000000000..8bc294fa6aa3bfc0ce34c49467cba979d25d1c32
GIT binary patch
literal 719
zcmV;=0x<oFP)<h;3K|Lk000e1NJLTq000mG000mO1^@s6AM^iV0000PbVXQnQ*UN;
zcVTj606}DLVr3vnZDD6+Qe|Oed2z{QJOBU!aY;l$RCwBqQ%h)5K@>gnd2L87CW2|f
zDq^aLLRT?hRDxSqMTpes#+^irNI=O#aN)+4(1iu1B2`j!Q7aX-(k_Ywn@apFR8Wd-
ziAwV^iA`<VzW2tN{2Nd_aCq;|n|tQm`|gm(V`Ev}Fl@p!A<zgF5l})v2uU%<9F$VE
z1cM9gj<;c@kO9|q-FCdU7ym*sncVs^8jWb0<|j&|0aS?cxnJkzB^NL^zfgLrSmAyo
z0*Awa!yeDcbzL78!fX<#yl~E-X?3btL7kXNr_s^Tfg>JIpKcltO(GyjB@dO#Ddm!+
zrfiz!^*!C)crh^n)uYpXKMa_@{WCV0TvP-^)d5w_s#}xZmX-@R;Bu8%h1w#Btec3k
z!FmGQK*l(VE2~JRGqQxA$Yk@SeKWB*+V<_j(x!H~kBXXrs+lpmf#tq%v{)>#v~5Nx
zd==*dLEQT?j9elMJ)Oi~9hAs4FwF{Pwc_37?YMHL2ZKWo;C3Cvb2<t4z*$#Kp!syh
zIkZ*_G^>U;Atw&`oUpwQp>J;<<KvU)zjodAHZU0HHG#$fk*%Su1w<owb<qj0Zzu3=
z5y=0-^y>(2-1_9Y5Dv$YGQjI4@Y?tiX<dcU;0}0C$mGNiAe+R^SSPytxAD|hjLU&W
zf|#JF{JPQrRhuT0a}hVZm(BsUqd+Es{^%A2?tFkz%)?k)g|V&!YtjL&Sf@=hKJsxJ
zy6_vvdfG8C?LctobNPd@F6V$LpXI-|TqsP9jE;Iubtlw(NFlA&irGa|UZNPB-+|6k
zck$@Svr=-Qury`2+w1L;bV}Or|Hw(sR)aqR3;;J*;t!9$I5PkM002ovPDHLkV1o9L
BQ0f2x

literal 0
HcmV?d00001