diff --git a/src/applications/differential/data/commitmessage/DifferentialCommitMessageData.php b/src/applications/differential/data/commitmessage/DifferentialCommitMessageData.php index 61aafe1e4f..7e31f7e24b 100644 --- a/src/applications/differential/data/commitmessage/DifferentialCommitMessageData.php +++ b/src/applications/differential/data/commitmessage/DifferentialCommitMessageData.php @@ -93,7 +93,7 @@ class DifferentialCommitMessageData { } $handles = id(new PhabricatorObjectHandleData($phids)) - ->loadHandles($handles); + ->loadHandles(); if ($this->mode == self::MODE_AMEND) { if ($reviewer) { diff --git a/src/applications/differential/parser/commitmessage/DifferentialCommitMessage.php b/src/applications/differential/parser/commitmessage/DifferentialCommitMessage.php index 152ef02d0e..42ad2d9d99 100755 --- a/src/applications/differential/parser/commitmessage/DifferentialCommitMessage.php +++ b/src/applications/differential/parser/commitmessage/DifferentialCommitMessage.php @@ -388,8 +388,6 @@ class DifferentialCommitMessage { $data = (int)preg_replace('/[^\d]/', '', $data); break; case 'CC': - $data = preg_replace('/\s+/', ' ', $data); - break; case 'Reviewers': case 'Reviewed By': $data = array_filter(preg_split('/[\s,]+/', $data)); diff --git a/src/view/page/standard/PhabricatorStandardPageView.php b/src/view/page/standard/PhabricatorStandardPageView.php index 660e09cc9b..3077055124 100755 --- a/src/view/page/standard/PhabricatorStandardPageView.php +++ b/src/view/page/standard/PhabricatorStandardPageView.php @@ -132,20 +132,23 @@ class PhabricatorStandardPageView extends AphrontPageView { $tabs = array(); foreach ($this->tabs as $name => $tab) { - $tabs[] = phutil_render_tag( + $tab_markup = phutil_render_tag( 'a', array( 'href' => idx($tab, 'href'), + ), + phutil_escape_html(idx($tab, 'name'))); + $tab_markup = phutil_render_tag( + 'td', + array( 'class' => ($name == $this->selectedTab) ? 'phabricator-selected-tab' : null, ), - phutil_escape_html(idx($tab, 'name'))); + $tab_markup); + $tabs[] = $tab_markup; } $tabs = implode('', $tabs); - if ($tabs) { - $tabs = ''.$tabs.''; - } $login_stuff = null; $request = $this->getRequest(); @@ -215,15 +218,25 @@ class PhabricatorStandardPageView extends AphrontPageView { '
'. + ''. + "Phabricat\xE2\x9A\x99r". + ' '. + ' | '. + ''. + phutil_render_tag( + 'a', + array( + 'href' => $this->getBaseURI(), + 'class' => 'phabricator-head-appname', + ), + phutil_escape_html($this->getApplicationName())). + ' | '. + $tabs. + '
---|