From 90078fe06ea53c1c9eecd0df3f25faa648cedeba Mon Sep 17 00:00:00 2001 From: epriestley Date: Thu, 18 Jun 2015 13:05:44 -0700 Subject: [PATCH] Clarify that 'order' is an optional parameter in Conduit API methods Summary: Fixes T8603. For automatic 'order' parameters provided by infrastructure en route to T7715, clarify that they are optional (we will use the default builtin order for the underlying Query if an order is not provided). Test Plan: Used web UI to see "optional" hint. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T8603 Differential Revision: https://secure.phabricator.com/D13342 --- src/applications/conduit/method/ConduitAPIMethod.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/conduit/method/ConduitAPIMethod.php b/src/applications/conduit/method/ConduitAPIMethod.php index a56f680432..4472f80864 100644 --- a/src/applications/conduit/method/ConduitAPIMethod.php +++ b/src/applications/conduit/method/ConduitAPIMethod.php @@ -30,7 +30,7 @@ abstract class ConduitAPIMethod $query = $this->newQueryObject(); if ($query) { - $types['order'] = 'order'; + $types['order'] = 'optional order'; $types += $this->getPagerParamTypes(); }