From 90258ed491d559b620c9e42663d526ef3fa316b1 Mon Sep 17 00:00:00 2001 From: epriestley Date: Wed, 18 Jan 2017 11:29:38 -0800 Subject: [PATCH] Fix property shadowing on ActionListView after conversion to TagView Summary: See D17222. D17209 accidentally broke setting IDs on ActionListView by converting it into a TagView: TagView already has an `id` property, and this new `id` property on the subclass shadows it. Materially, the "Actions" mobile button in the headers of objects (for example: Maniphest Task -> shrink browser window -> click "Actions" next to task name) relies on setting IDs on list views. Test Plan: - Viewed a task. - Made browser window narrow. - Clicked `[= Actions]` button. - After patch: saw a dropdown menu. Reviewers: chad Reviewed By: chad Differential Revision: https://secure.phabricator.com/D17223 --- src/view/layout/PhabricatorActionListView.php | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/src/view/layout/PhabricatorActionListView.php b/src/view/layout/PhabricatorActionListView.php index 5ac28f81de..faf30555eb 100644 --- a/src/view/layout/PhabricatorActionListView.php +++ b/src/view/layout/PhabricatorActionListView.php @@ -4,7 +4,6 @@ final class PhabricatorActionListView extends AphrontTagView { private $actions = array(); private $object; - private $id = null; public function setObject(PhabricatorLiskDAO $object) { $this->object = $object; @@ -16,15 +15,6 @@ final class PhabricatorActionListView extends AphrontTagView { return $this; } - public function setID($id) { - $this->id = $id; - return $this; - } - - public function getID() { - return $this->id; - } - protected function getTagName() { return 'ul'; }