revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 17:52:43 +01:00
Code Issues Releases Wiki Activity

(stable) When proxying cluster HTTP requests, forward only selected headers

Browse source 
In the live cluster, some subset of the forwarded headers are creating
some issues for HTTP repository operations.
This commit is contained in:
epriestley 2016-04-09 03:39:17 -07:00
parent bf10fbdf6f
commit 908c29cb97
1 changed files with 19 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/aphront/AphrontRequest.php
View file

@ -754,7 +754,10 @@ final class AphrontRequest extends Phobject {
// NOTE: apache_request_headers() might provide a nicer way to do this,
// but isn't available under FCGI until PHP 5.4.0.
foreach ($_SERVER as $key => $value) {
if (preg_match('/^HTTP_/', $key)) {
if (!preg_match('/^HTTP_/', $key)) {
continue;
}
// Unmangle the header as best we can.
$key = substr($key, strlen('HTTP_'));
$key = str_replace('_', ' ', $key);
@ -762,6 +765,15 @@ final class AphrontRequest extends Phobject {
$key = ucwords($key);
$key = str_replace(' ', '-', $key);
// By default, do not forward headers.
$should_forward = false;
// Forward "X-Hgarg-..." headers.
if (preg_match('/^X-Hgarg-/', $key)) {
$should_forward = true;
}
if ($should_forward) {
$headers[] = array($key, $value);
$seen[$key] = true;
}