Linter fixes

Summary: Minor linter fixes.

Test Plan: N/A

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D14631

src/applications/calendar/util/CalendarTimeUtil.php

@@ -1,4 +1,5 @@
 <?php
+
 /**
  * This class is useful for generating various time objects, relative to the
  * user and their timezone.

src/applications/diviner/cache/DivinerAtomCache.php

@@ -13,7 +13,7 @@ final class DivinerAtomCache extends DivinerDiskCache {
   private $writeAtoms = array();
 
   public function __construct($cache_directory) {
-    return parent::__construct($cache_directory, 'diviner-atom-cache');
+    parent::__construct($cache_directory, 'diviner-atom-cache');
   }
 
   public function delete() {

src/applications/diviner/cache/DivinerPublishCache.php

@@ -6,7 +6,7 @@ final class DivinerPublishCache extends DivinerDiskCache {
   private $index;
 
   public function __construct($cache_directory) {
-    return parent::__construct($cache_directory, 'diviner-publish-cache');
+    parent::__construct($cache_directory, 'diviner-publish-cache');
   }
 
 

src/applications/files/engine/PhabricatorChunkedFileStorageEngine.php

@@ -143,7 +143,7 @@ final class PhabricatorChunkedFileStorageEngine
    */
   private function getWritableEngine() {
     // NOTE: We can't just load writable engines or we'll loop forever.
-    $engines = PhabricatorFileStorageEngine::loadAllEngines();
+    $engines = parent::loadAllEngines();
 
     foreach ($engines as $engine) {
       if ($engine->isChunkEngine()) {

src/applications/home/controller/PhabricatorHomeMainController.php

@@ -219,7 +219,7 @@ final class PhabricatorHomeMainController extends PhabricatorHomeController {
 
     $revisions = $revision_query->execute();
 
-    list($blocking, $active,) = DifferentialRevisionQuery::splitResponsible(
+    list($blocking, $active) = DifferentialRevisionQuery::splitResponsible(
         $revisions,
         array($user_phid));
 

src/applications/oauthserver/PhabricatorOAuthResponse.php

@@ -66,7 +66,6 @@ final class PhabricatorOAuthResponse extends AphrontResponse {
 
   public function __construct() {
     $this->setHTTPResponseCode(200); // assume the best
-    return $this;
   }
 
   public function getHeaders() {

src/applications/oauthserver/PhabricatorOAuthServer.php

@@ -64,8 +64,8 @@ final class PhabricatorOAuthServer extends Phobject {
    */
   public function userHasAuthorizedClient(array $scope) {
 
-    $authorization = id(new PhabricatorOAuthClientAuthorization())->
+    $authorization = id(new PhabricatorOAuthClientAuthorization())
-      loadOneWhere(
+      ->loadOneWhere(
         'userPHID = %s AND clientPHID = %s',
         $this->getUser()->getPHID(),
         $this->getClient()->getPHID());

src/applications/phame/controller/PhameController.php

@@ -1,5 +1,3 @@
 <?php
 
-abstract class PhameController extends PhabricatorController {
+abstract class PhameController extends PhabricatorController {}
-
-}

src/applications/releeph/storage/ReleephRequestTransaction.php

@@ -77,7 +77,7 @@ final class ReleephRequestTransaction
 
         $markup = $name;
         if ($this->getRenderingTarget() ===
-          PhabricatorApplicationTransaction::TARGET_HTML) {
+          parent::TARGET_HTML) {
 
           $markup = hsprintf('<em>%s</em>', $name);
         }

src/infrastructure/lint/linter/PhabricatorJavelinLinter.php

@@ -85,7 +85,7 @@ final class PhabricatorJavelinLinter extends ArcanistLinter {
   }
 
   public function getCacheGranularity() {
-    return ArcanistLinter::GRANULARITY_REPOSITORY;
+    return parent::GRANULARITY_REPOSITORY;
   }
 
   public function getCacheVersion() {

src/view/widget/bars/AphrontGlyphBarView.php

@@ -12,7 +12,7 @@ final class AphrontGlyphBarView extends AphrontBarView {
   private $bgGlyph;
 
   protected function getDefaultColor() {
-    return AphrontBarView::COLOR_AUTO_GOODNESS;
+    return parent::COLOR_AUTO_GOODNESS;
   }
 
   public function setValue($value) {

src/view/widget/bars/AphrontProgressBarView.php

@@ -9,7 +9,7 @@ final class AphrontProgressBarView extends AphrontBarView {
   private $alt = '';
 
   protected function getDefaultColor() {
-    return AphrontBarView::COLOR_AUTO_BADNESS;
+    return parent::COLOR_AUTO_BADNESS;
   }
 
   public function setValue($value) {