mirror of
https://we.phorge.it/source/phorge.git
synced 2025-02-02 01:48:23 +01:00
Fix PHP 8.1 "strlen(null)" exceptions which block rendering Legalpad signatures
Summary: `strlen()` was used in Phabricator to check if a generic value is a non-empty string. This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement. Note: this may highlight other absurd input values that might be worth correcting instead of just ignoring. If phutil_nonempty_string() throws an exception in your instance, report it to Phorge to evaluate and fix that specific corner case. Closes T15395 Test Plan: Applied these two changes; afterwards "All Signatures" page at `/legalpad/signatures/1/` gets rendered in web browser. Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Maniphest Tasks: T15395 Differential Revision: https://we.phorge.it/D25226
This commit is contained in:
parent
26aed4935b
commit
912a933b02
1 changed files with 2 additions and 2 deletions
|
@ -127,12 +127,12 @@ final class LegalpadDocumentSignatureSearchEngine
|
|||
}
|
||||
|
||||
$name_contains = $saved->getParameter('nameContains');
|
||||
if (strlen($name_contains)) {
|
||||
if (phutil_nonempty_string($name_contains)) {
|
||||
$query->withNameContains($name_contains);
|
||||
}
|
||||
|
||||
$email_contains = $saved->getParameter('emailContains');
|
||||
if (strlen($email_contains)) {
|
||||
if (phutil_nonempty_string($email_contains)) {
|
||||
$query->withEmailContains($email_contains);
|
||||
}
|
||||
|
||||
|
|
Loading…
Add table
Reference in a new issue