revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-18 11:30:55 +01:00
Code Issues Releases Wiki Activity

Maniphest - convert old CC transactions to modern SUBSCRIBER transactions

Browse source 
Summary: database migration + drop old view code. Fixes T5604.

Test Plan: grepped src/ for TYPE_CCS (no hits); viewed some tasks with old cc transactions and noted they still rendered correctly post data conversion

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T5604

Differential Revision: https://secure.phabricator.com/D11015
This commit is contained in:
Bob Trahan 2014-12-18 14:42:46 -08:00
parent 8ff9d52a59
commit 9141da84c8
2 changed files with 23 additions and 28 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
resources/sql/autopatches/20141218.maniphestcctxn.php Normal file
View file

@ -0,0 +1,20 @@
<?php
$table = new ManiphestTransaction();
$conn_w = $table->establishConnection('w');
echo "Converting Maniphest CC transactions to modern SUBSCRIBER ".
"transactions...\n";
foreach (new LiskMigrationIterator($table) as $txn) {
// ManiphestTransaction::TYPE_CCS
if ($txn->getTransactionType() == 'ccs') {
queryfx(
$conn_w,
'UPDATE %T SET transactionType = %s WHERE id = %d',
$table->getTableName(),
PhabricatorTransactions::TYPE_SUBSCRIBERS,
$txn->getID());
}
}
echo "Done.\n";

31
src/applications/maniphest/storage/ManiphestTransaction.php
View file

@ -7,26 +7,23 @@ final class ManiphestTransaction
const TYPE_STATUS = 'status';
const TYPE_DESCRIPTION = 'description';
const TYPE_OWNER = 'reassign';
const TYPE_PROJECTS = 'projects';
const TYPE_PRIORITY = 'priority';
const TYPE_EDGE = 'edge';
const TYPE_SUBPRIORITY = 'subpriority';
const TYPE_PROJECT_COLUMN = 'projectcolumn';
const TYPE_MERGED_INTO = 'mergedinto';
const TYPE_MERGED_FROM = 'mergedfrom';
const TYPE_UNBLOCK = 'unblock';
// NOTE: this type is deprecated. Keep it around for legacy installs
// so any transactions render correctly.
const TYPE_ATTACH = 'attach';
/**
* TYPE_CCS is legacy and depracted in favor of
* PhabricatorTransactions::TYPE_SUBSCRIBERS; keep it around for legacy
* TYPE_PROJECTS is legacy and depracted in favor of
* PhabricatorTransactions::TYPE_EDGE; keep it around for legacy
* transaction-rendering.
*/
const TYPE_CCS = 'ccs';
const TYPE_PROJECTS = 'projects';
const MAILTAG_STATUS = 'maniphest-status';
const MAILTAG_OWNER = 'maniphest-owner';
@ -90,7 +87,6 @@ final class ManiphestTransaction
$phids[] = $old;
}
break;
case self::TYPE_CCS:
case self::TYPE_PROJECTS:
$phids = array_mergev(
array(
@ -271,9 +267,6 @@ final class ManiphestTransaction
return pht('Reassigned');
}
case self::TYPE_CCS:
return pht('Changed CC');
case self::TYPE_PROJECTS:
return pht('Changed Projects');
@ -325,9 +318,6 @@ final class ManiphestTransaction
case self::TYPE_OWNER:
return 'fa-user';
case self::TYPE_CCS:
return 'fa-envelope';
case self::TYPE_TITLE:
if ($old === null) {
return 'fa-pencil';
@ -546,13 +536,6 @@ final class ManiphestTransaction
$new_name);
}
case self::TYPE_CCS:
// TODO: Remove this when we switch to subscribers. Just reuse the
// code in the parent.
$clone = clone $this;
$clone->setTransactionType(PhabricatorTransactions::TYPE_SUBSCRIBERS);
return $clone->getTitle();
case self::TYPE_EDGE:
// TODO: Remove this when we switch to real edges. Just reuse the
// code in the parent;
@ -801,13 +784,6 @@ final class ManiphestTransaction
$new_name);
}
case self::TYPE_CCS:
// TODO: Remove this when we switch to subscribers. Just reuse the
// code in the parent.
$clone = clone $this;
$clone->setTransactionType(PhabricatorTransactions::TYPE_SUBSCRIBERS);
return $clone->getTitleForFeed($story);
case self::TYPE_EDGE:
// TODO: Remove this when we switch to real edges. Just reuse the
// code in the parent;
@ -902,7 +878,6 @@ final class ManiphestTransaction
case self::TYPE_OWNER:
$tags[] = self::MAILTAG_OWNER;
break;
case self::TYPE_CCS:
case PhabricatorTransactions::TYPE_SUBSCRIBERS:
$tags[] = self::MAILTAG_CC;
break;