From 91a1f56a4c252abf3725f7789940b723a59b5699 Mon Sep 17 00:00:00 2001 From: Bob Trahan Date: Tue, 10 Feb 2015 12:07:18 -0800 Subject: [PATCH] Subversion - set minimum required version to 1.5 Summary: Fixes T7228. Test Plan: hacked $version to be '1.4' and saw the proper error message Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7228 Differential Revision: https://secure.phabricator.com/D11732 --- .../config/check/PhabricatorBinariesSetupCheck.php | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/applications/config/check/PhabricatorBinariesSetupCheck.php b/src/applications/config/check/PhabricatorBinariesSetupCheck.php index fb45f2ed7c..3df43e8546 100644 --- a/src/applications/config/check/PhabricatorBinariesSetupCheck.php +++ b/src/applications/config/check/PhabricatorBinariesSetupCheck.php @@ -102,11 +102,11 @@ final class PhabricatorBinariesSetupCheck extends PhabricatorSetupCheck { $version = trim(substr($stdout, strlen('git version '))); break; case PhabricatorRepositoryType::REPOSITORY_TYPE_SVN: - $minimum_version = null; + $minimum_version = '1.5'; $bad_versions = array( '1.7.1' => pht('This version of Subversion has a bug where '. '"svn diff -c N" does not work for files added '. - 'in rN (Subverison issue #2873), fixed in 1.7.2.'),); + 'in rN (Subversion issue #2873), fixed in 1.7.2.'),); list($err, $stdout, $stderr) = exec_manual('svn --version --quiet'); $version = trim($stdout); break; @@ -232,7 +232,6 @@ final class PhabricatorBinariesSetupCheck extends PhabricatorSetupCheck { case PhabricatorRepositoryType::REPOSITORY_TYPE_GIT: break; case PhabricatorRepositoryType::REPOSITORY_TYPE_SVN: - break; case PhabricatorRepositoryType::REPOSITORY_TYPE_MERCURIAL: $summary = pht( "The '%s' binary is version %s and Phabricator requires version ".