revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-22 13:30:55 +01:00
Code Issues Releases Wiki Activity

Use the task title as the page title for Maniphest task detail views.

Browse source 
Summary: Instead of "Create Task", show the task's ID and name in the page
title.

Test Plan: Looked at a task. Also double-cheked XSS junk and plugged a hole.

Reviewers: cpiro

CC:

Differential Revision: 27
This commit is contained in:
epriestley 2011-02-09 16:38:31 -08:00
parent 5d586f149d
commit 91fb157253
4 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/maniphest/controller/taskdetail/ManiphestTaskDetailController.php
View file

@ -234,7 +234,7 @@ class ManiphestTaskDetailController extends ManiphestController {
$comment_panel, $comment_panel,
), ),
array( array(
'title' => 'Create Task', 'title' => 'T'.$task->getID().' '.$task->getTitle(),
)); ));
} }
} }

1
src/applications/maniphest/controller/tasklist/ManiphestTaskListController.php
View file

@ -38,7 +38,6 @@ class ManiphestTaskListController extends ManiphestController {
'alltriage' => 'Need Triage', 'alltriage' => 'Need Triage',
'unassigned' => 'Unassigned', 'unassigned' => 'Unassigned',
'allopen' => 'All Open', 'allopen' => 'All Open',
); );
if (empty($views[$this->view])) { if (empty($views[$this->view])) {

2
src/view/page/base/AphrontPageView.php
View file

@ -53,7 +53,7 @@ class AphrontPageView extends AphrontView {
$this->willRenderPage(); $this->willRenderPage();
$title = $this->getTitle(); $title = phutil_escape_html($this->getTitle());
$head = $this->getHead(); $head = $this->getHead();
$body = $this->getBody(); $body = $this->getBody();
$tail = $this->getTail(); $tail = $this->getTail();

2
src/view/page/base/__init__.php
View file

@ -8,5 +8,7 @@
phutil_require_module('phabricator', 'view/base'); phutil_require_module('phabricator', 'view/base');
phutil_require_module('phutil', 'markup');
phutil_require_source('AphrontPageView.php'); phutil_require_source('AphrontPageView.php');