mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-20 20:40:56 +01:00
Allow Herald to add package reviewers
Summary: Ref T10939. Packages are valid reviewers, so let Herald "Add Reviewers" and "Add Blocking Reviewers" actions add them. Test Plan: - Wrote a rule to add package reviewers. - Hit the rule, saw a package reviewer added, viewed transcript. {F1311731} {F1311732} {F1311733} Reviewers: chad Reviewed By: chad Maniphest Tasks: T10939 Differential Revision: https://secure.phabricator.com/D15917
This commit is contained in:
parent
332d787dc8
commit
92b9fa47d0
3 changed files with 3 additions and 2 deletions
|
@ -22,7 +22,7 @@ final class DifferentialReviewersAddBlockingReviewersHeraldAction
|
||||||
}
|
}
|
||||||
|
|
||||||
protected function getDatasource() {
|
protected function getDatasource() {
|
||||||
return new PhabricatorMetaMTAMailableDatasource();
|
return new DiffusionAuditorDatasource();
|
||||||
}
|
}
|
||||||
|
|
||||||
public function renderActionDescription($value) {
|
public function renderActionDescription($value) {
|
||||||
|
|
|
@ -22,7 +22,7 @@ final class DifferentialReviewersAddReviewersHeraldAction
|
||||||
}
|
}
|
||||||
|
|
||||||
protected function getDatasource() {
|
protected function getDatasource() {
|
||||||
return new PhabricatorMetaMTAMailableDatasource();
|
return new DiffusionAuditorDatasource();
|
||||||
}
|
}
|
||||||
|
|
||||||
public function renderActionDescription($value) {
|
public function renderActionDescription($value) {
|
||||||
|
|
|
@ -69,6 +69,7 @@ abstract class DifferentialReviewersHeraldAction
|
||||||
$allowed_types = array(
|
$allowed_types = array(
|
||||||
PhabricatorPeopleUserPHIDType::TYPECONST,
|
PhabricatorPeopleUserPHIDType::TYPECONST,
|
||||||
PhabricatorProjectProjectPHIDType::TYPECONST,
|
PhabricatorProjectProjectPHIDType::TYPECONST,
|
||||||
|
PhabricatorOwnersPackagePHIDType::TYPECONST,
|
||||||
);
|
);
|
||||||
|
|
||||||
$targets = $this->loadStandardTargets($phids, $allowed_types, $current);
|
$targets = $this->loadStandardTargets($phids, $allowed_types, $current);
|
||||||
|
|
Loading…
Reference in a new issue