revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-19 03:50:54 +01:00
Code Issues Releases Wiki Activity

Create an empty state for dashboards

Browse source 
Summary: Fixes T5177. Not sure if checking for panelPHIDs is right, but seemed like a better choice than adding a new property on dashboard.

Test Plan: Create dashboard with no panels. Go to view dashboard. "view" page should have a placeholder that directs user to Manage Dashboard

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin

Maniphest Tasks: T5177

Differential Revision: https://secure.phabricator.com/D9312
This commit is contained in:
lkassianik 2014-05-27 15:34:41 -07:00 committed by epriestley
parent 33aa395806
commit 92ccadaa42
1 changed files with 24 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
src/applications/dashboard/controller/PhabricatorDashboardViewController.php
View file

@ -26,10 +26,14 @@ final class PhabricatorDashboardViewController
$crumbs = $this->buildApplicationCrumbs(); $crumbs = $this->buildApplicationCrumbs();
$crumbs->addTextCrumb(pht('Dashboard %d', $dashboard->getID())); $crumbs->addTextCrumb(pht('Dashboard %d', $dashboard->getID()));
$rendered_dashboard = id(new PhabricatorDashboardRenderingEngine()) if ($dashboard->getPanelPHIDs()) {
->setViewer($viewer) $rendered_dashboard = id(new PhabricatorDashboardRenderingEngine())
->setDashboard($dashboard) ->setViewer($viewer)
->renderDashboard(); ->setDashboard($dashboard)
->renderDashboard();
} else {
$rendered_dashboard = $this->buildEmptyView();
}
return $this->buildApplicationPage( return $this->buildApplicationPage(
array( array(
@ -50,9 +54,24 @@ final class PhabricatorDashboardViewController
id(new PHUIListItemView()) id(new PHUIListItemView())
->setIcon('fa-th') ->setIcon('fa-th')
->setName(pht('Manage Dashboard')) ->setName(pht('Manage Dashboard'))
->setHref($this->getApplicationURI()."manage/{$id}/")); ->setHref($this->getApplicationURI("manage/{$id}/")));
return $crumbs; return $crumbs;
} }
public function buildEmptyView() {
$id = $this->id;
$manage_uri = $this->getApplicationURI("manage/{$id}/");
return id(new AphrontErrorView())
->setSeverity(AphrontErrorView::SEVERITY_NODATA)
->appendChild(
pht('This dashboard has no panels '.
'yet. Use %s to add panels.',
phutil_tag(
'a',
array('href'=>$manage_uri),
pht('Manage Dashboard'))));
}
} }