mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-22 13:30:55 +01:00
Stop two special cache writes in read-only mode
Summary: Ref T10769. The user availability cache write shouldn't happen in read-only mode, nor should the Differential parse cache write. (We might want to turn off the availbility feature completely since it's potentially expensive if we can't cache it, but I think we're OK for now.) Test Plan: In read-only mode: - Browsed as a user with an out-of-date availability cache. - Loaded an older revision without cached parse data. Reviewers: chad Reviewed By: chad Maniphest Tasks: T10769 Differential Revision: https://secure.phabricator.com/D15988
This commit is contained in:
parent
fb1cc8cc58
commit
92ea4fb098
2 changed files with 8 additions and 0 deletions
|
@ -458,6 +458,10 @@ final class DifferentialChangesetParser extends Phobject {
|
||||||
}
|
}
|
||||||
|
|
||||||
public function saveCache() {
|
public function saveCache() {
|
||||||
|
if (PhabricatorEnv::isReadOnly()) {
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
|
||||||
if ($this->highlightErrors) {
|
if ($this->highlightErrors) {
|
||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
|
|
|
@ -968,6 +968,10 @@ final class PhabricatorUser
|
||||||
* @task availability
|
* @task availability
|
||||||
*/
|
*/
|
||||||
public function writeAvailabilityCache(array $availability, $ttl) {
|
public function writeAvailabilityCache(array $availability, $ttl) {
|
||||||
|
if (PhabricatorEnv::isReadOnly()) {
|
||||||
|
return $this;
|
||||||
|
}
|
||||||
|
|
||||||
$unguarded = AphrontWriteGuard::beginScopedUnguardedWrites();
|
$unguarded = AphrontWriteGuard::beginScopedUnguardedWrites();
|
||||||
queryfx(
|
queryfx(
|
||||||
$this->establishConnection('w'),
|
$this->establishConnection('w'),
|
||||||
|
|
Loading…
Reference in a new issue