revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 14:52:41 +01:00
Code Issues Releases Wiki Activity

Fix a warning in BoardLayoutEngine when no objects are being updated

Browse source 
Summary: Fixes T13368. Some workflows (like "Move tasks to...") execute board layout without objects to update. In these cases, we can hit a warning because `objectPHIDs` is not initialized to `array()`.

Test Plan: Went through the "Move tasks to..." workflow on a workboard, no longer saw a warning when trying to iterate over an empty `objectPHIDs` list.

Maniphest Tasks: T13368

Differential Revision: https://secure.phabricator.com/D20701
This commit is contained in:
epriestley 2019-08-07 09:04:39 -07:00
parent 0561043a1f
commit 937edcdc58
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/project/engine/PhabricatorBoardLayoutEngine.php
View file

@ -4,7 +4,7 @@ final class PhabricatorBoardLayoutEngine extends Phobject {
private $viewer;
private $boardPHIDs;
private $objectPHIDs;
private $objectPHIDs = array();
private $boards;
private $columnMap = array();
private $objectColumnMap = array();