Remove unnecessary empty checks from willFilterPage()

Summary: Fixes T3600. These checks are obsolete after D6512.

Test Plan: Syntax / static / inspection.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T3600

Differential Revision: https://secure.phabricator.com/D6563

src/applications/differential/query/DifferentialRevisionQuery.php

@@ -360,10 +360,6 @@ final class DifferentialRevisionQuery
   }
 
   public function willFilterPage(array $revisions) {
-    if (!$revisions) {
-      return $revisions;
-    }
-
     $table = new DifferentialRevision();
     $conn_r = $table->establishConnection('r');
 

src/applications/diviner/query/DivinerAtomQuery.php

@@ -75,10 +75,6 @@ final class DivinerAtomQuery
   }
 
   protected function willFilterPage(array $atoms) {
-    if (!$atoms) {
-      return $atoms;
-    }
-
     $books = array_unique(mpull($atoms, 'getBookPHID'));
 
     $books = id(new DivinerBookQuery())

src/applications/legalpad/query/LegalpadDocumentQuery.php

@@ -75,10 +75,6 @@ final class LegalpadDocumentQuery
   }
 
   protected function willFilterPage(array $documents) {
-    if (!$documents) {
-      return $documents;
-    }
-
     if ($this->needDocumentBodies) {
       $documents = $this->loadDocumentBodies($documents);
     }

src/applications/macro/query/PhabricatorMacroQuery.php

@@ -157,10 +157,6 @@ final class PhabricatorMacroQuery
   }
 
   protected function willFilterPage(array $macros) {
-    if (!$macros) {
-      return array();
-    }
-
     $file_phids = mpull($macros, 'getFilePHID');
     $files = id(new PhabricatorFileQuery())
       ->setViewer($this->getViewer())

src/applications/paste/query/PhabricatorPasteQuery.php

@@ -85,10 +85,6 @@ final class PhabricatorPasteQuery
   }
 
   protected function willFilterPage(array $pastes) {
-    if (!$pastes) {
-      return $pastes;
-    }
-
     if ($this->needRawContent) {
       $pastes = $this->loadRawContent($pastes);
     }

src/applications/phortune/query/PhortuneAccountQuery.php

@@ -39,10 +39,6 @@ final class PhortuneAccountQuery
   }
 
   protected function willFilterPage(array $accounts) {
-    if (!$accounts) {
-      return array();
-    }
-
     $query = id(new PhabricatorEdgeQuery())
       ->withSourcePHIDs(mpull($accounts, 'getPHID'))
       ->withEdgeTypes(array(PhabricatorEdgeConfig::TYPE_ACCOUNT_HAS_MEMBER));

src/applications/phortune/query/PhortunePaymentMethodQuery.php

@@ -47,10 +47,6 @@ final class PhortunePaymentMethodQuery
   }
 
   protected function willFilterPage(array $methods) {
-    if (!$methods) {
-      return array();
-    }
-
     $accounts = id(new PhortuneAccountQuery())
       ->setViewer($this->getViewer())
       ->withPHIDs(mpull($methods, 'getAccountPHID'))

src/applications/phriction/query/PhrictionDocumentQuery.php

@@ -60,10 +60,6 @@ final class PhrictionDocumentQuery
   }
 
   protected function willFilterPage(array $documents) {
-    if (!$documents) {
-      return array();
-    }
-
     $contents = id(new PhrictionContent())->loadAllWhere(
       'id IN (%Ld)',
       mpull($documents, 'getContentID'));

src/applications/slowvote/query/PhabricatorSlowvoteQuery.php

@@ -69,10 +69,6 @@ final class PhabricatorSlowvoteQuery
   public function willFilterPage(array $polls) {
     assert_instances_of($polls, 'PhabricatorSlowvotePoll');
 
-    if (!$polls) {
-      return array();
-    }
-
     $ids = mpull($polls, 'getID');
     $viewer = $this->getViewer();
 

src/applications/tokens/query/PhabricatorTokenReceiverQuery.php

@@ -19,10 +19,6 @@ final class PhabricatorTokenReceiverQuery
   }
 
   public function willFilterPage(array $phids) {
-    if (!$phids) {
-      return array();
-    }
-
     $objects = id(new PhabricatorObjectHandleData($phids))
       ->setViewer($this->getViewer())
       ->loadObjects();