mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-21 04:50:55 +01:00
Use PhutilProxyException to disambiguate repository pull errors
Summary: Ref T2569. When repository pulls fail, they don't necessarily list identifying information about which repository failed. Use a proxy exception to list that information. Test Plan: {F51267} Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2569 Differential Revision: https://secure.phabricator.com/D6548
This commit is contained in:
parent
88530ba053
commit
938b5c69c6
1 changed files with 7 additions and 2 deletions
|
@ -117,8 +117,9 @@ final class PhabricatorRepositoryPullLocalDaemon
|
|||
continue;
|
||||
}
|
||||
|
||||
$callsign = $repository->getCallsign();
|
||||
|
||||
try {
|
||||
$callsign = $repository->getCallsign();
|
||||
$this->log("Updating repository '{$callsign}'.");
|
||||
|
||||
id(new PhabricatorRepositoryPullEngine())
|
||||
|
@ -150,7 +151,11 @@ final class PhabricatorRepositoryPullLocalDaemon
|
|||
$this->log("Failed to acquire lock.");
|
||||
} catch (Exception $ex) {
|
||||
$retry_after[$id] = time() + $min_sleep;
|
||||
phlog($ex);
|
||||
|
||||
$proxy = new PhutilProxyException(
|
||||
"Error while fetching changes to the '{$callsign}' repository.",
|
||||
$ex);
|
||||
phlog($proxy);
|
||||
}
|
||||
|
||||
$this->stillWorking();
|
||||
|
|
Loading…
Reference in a new issue