mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-10 08:52:39 +01:00
Be less strict when detecting dead daemons
Summary: Fixes T12306. Currently, we warn about daemons not running even if they're in normal "alive" states, particularly "waiting to restart after a failure". This check was made more strict in D12088, back when we tried to version check running daemons. Since we implemented auto-restart-after-config-change we don't do this anymore, so it should be fine to make this more lax again. Test Plan: - Faked an exception for all tasks. - Before patch: reloading the daemon setup error sometimes raised a false positive ("waiting" daemon detected as dead). - After patch: daemon setup error no longer triggers. Reviewers: chad Reviewed By: chad Maniphest Tasks: T12306 Differential Revision: https://secure.phabricator.com/D17397
This commit is contained in:
parent
6f50729a91
commit
939fb69aa6
1 changed files with 1 additions and 1 deletions
|
@ -10,7 +10,7 @@ final class PhabricatorDaemonsSetupCheck extends PhabricatorSetupCheck {
|
|||
|
||||
$task_daemon = id(new PhabricatorDaemonLogQuery())
|
||||
->setViewer(PhabricatorUser::getOmnipotentUser())
|
||||
->withStatus(PhabricatorDaemonLogQuery::STATUS_RUNNING)
|
||||
->withStatus(PhabricatorDaemonLogQuery::STATUS_ALIVE)
|
||||
->withDaemonClasses(array('PhabricatorTaskmasterDaemon'))
|
||||
->setLimit(1)
|
||||
->execute();
|
||||
|
|
Loading…
Reference in a new issue