revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-29 18:22:41 +01:00
Code Issues Releases Wiki Activity

Check for strlen instead of null for Maniphest title

Browse source 
Summary: Fixes T12744. Unclear why `null` doesn't work here but does for the title, but `!strlen` seems to work fine in both cases.

Test Plan: Create a new task, check mail folder, see [Created]

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Maniphest Tasks: T12744

Differential Revision: https://secure.phabricator.com/D18002
This commit is contained in:
Chad Little 2017-05-23 16:59:15 +00:00 committed by chad
parent 20e7f7d0e2
commit 93d8b33cca
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/applications/maniphest/xaction/ManiphestTaskTitleTransaction.php
View file

@ -19,8 +19,8 @@ final class ManiphestTaskTitleTransaction
public function getActionName() { public function getActionName() {
$old = $this->getOldValue(); $old = $this->getOldValue();
$new = $this->getNewValue();
if ($old === null) { if (!strlen($old)) {
return pht('Created'); return pht('Created');
} }
@ -29,7 +29,8 @@ final class ManiphestTaskTitleTransaction
public function getTitle() { public function getTitle() {
$old = $this->getOldValue(); $old = $this->getOldValue();
if ($old === null) {
if (!strlen($old)) {
return pht( return pht(
'%s created this task.', '%s created this task.',
$this->renderAuthor()); $this->renderAuthor());