revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-22 13:30:55 +01:00
Code Issues Releases Wiki Activity

Support - Differential - fix rendering feed story where you removed a repository

Browse source 
Summary: Fixes T6176. Language here is a bit awkard but I wanted to use the verb "removed" *and* still have the object first, so I ended up adding the before details parenthetically.

Test Plan: story no longer fatal'd in my feed

Reviewers: epriestley, chad

Reviewed By: chad

Subscribers: epriestley, Korvin

Maniphest Tasks: T6176

Differential Revision: https://secure.phabricator.com/D10549
This commit is contained in:
Bob Trahan 2014-09-24 12:09:59 -07:00
parent 11f6b01428
commit 93e1978e05
1 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/applications/differential/customfield/DifferentialRepositoryField.php
View file

@ -107,19 +107,25 @@ final class DifferentialRepositoryField
$old = $xaction->getOldValue(); $old = $xaction->getOldValue();
$new = $xaction->getNewValue(); $new = $xaction->getNewValue();
if ($old) { if ($old && $new) {
return pht( return pht(
'%s updated the repository for %s from %s to %s.', '%s updated the repository for %s from %s to %s.',
$xaction->renderHandleLink($author_phid), $xaction->renderHandleLink($author_phid),
$xaction->renderHandleLink($object_phid), $xaction->renderHandleLink($object_phid),
$xaction->renderHandleLink($old), $xaction->renderHandleLink($old),
$xaction->renderHandleLink($new)); $xaction->renderHandleLink($new));
} else { } else if ($new) {
return pht( return pht(
'%s set the repository for %s to %s.', '%s set the repository for %s to %s.',
$xaction->renderHandleLink($author_phid), $xaction->renderHandleLink($author_phid),
$xaction->renderHandleLink($object_phid), $xaction->renderHandleLink($object_phid),
$xaction->renderHandleLink($new)); $xaction->renderHandleLink($new));
} else {
return pht(
'%s removed the repository for %s. (Repository was %s.)',
$xaction->renderHandleLink($author_phid),
$xaction->renderHandleLink($object_phid),
$xaction->renderHandleLink($old));
} }
} }