From 93ef902ffa3c47de45dc00b722c7e7849d3449e8 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Tue, 8 Sep 2020 12:00:05 -0700
Subject: [PATCH] Fix a view fatal in CommitGraphView when commits are
 undiscovered

Summary:
Ref T13552. See <https://discourse.phabricator-community.org/t/viewing-repository-history-for-svn-repository-causes-unhandled-exception/4225/>.

This condition is flipped and can fatal by passing a `NULL` value for `$commit` to a typehinted method.

Test Plan: Viewed history page with undiscovered commits.

Maniphest Tasks: T13552

Differential Revision: https://secure.phabricator.com/D21458
---
 src/applications/diffusion/view/DiffusionCommitGraphView.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/applications/diffusion/view/DiffusionCommitGraphView.php b/src/applications/diffusion/view/DiffusionCommitGraphView.php
index a43f44f033..2009328a9d 100644
--- a/src/applications/diffusion/view/DiffusionCommitGraphView.php
+++ b/src/applications/diffusion/view/DiffusionCommitGraphView.php
@@ -485,7 +485,7 @@ final class DiffusionCommitGraphView
     $buildable = null;
 
     $commit = $this->getCommit($hash);
-    if (!$commit) {
+    if ($commit) {
       $buildable = $this->getBuildable($commit);
     }