revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 06:42:42 +01:00
Code Issues Releases Wiki Activity

log deprecation events in Dark Console

Browse source 
Summary:
`PhutilErrorHandler` already defines "DEPRECATED" error class, but it's not used.
I plan to use it to report deprecation warnings.

With this change, they will be shown in the Dark Console and in the error logs

Ref T15554

This change on its own won't do anything, but is safe to land first.

Test Plan: With D25387, pages that have deprecation warnings are now shown, and the deprecation message is available in the dark console (and in log).

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15554

Differential Revision: https://we.phorge.it/D25386
This commit is contained in:
Aviv Eyal 2023-08-31 08:17:01 -07:00
parent aeab4efe17
commit 94c0774d80
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/applications/console/plugin/errorlog/DarkConsoleErrorLogPluginAPI.php
View file

@ -44,6 +44,7 @@ final class DarkConsoleErrorLogPluginAPI extends Phobject {
'trace' => $metadata['trace'], 'trace' => $metadata['trace'],
); );
break; break;
case PhutilErrorHandler::DEPRECATED:
case PhutilErrorHandler::ERROR: case PhutilErrorHandler::ERROR:
// $value is a simple string // $value is a simple string
self::$errors[] = array( self::$errors[] = array(