revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-09 16:32:39 +01:00
Code Issues Releases Wiki Activity

Fix bad tables in diffusion blame

Browse source 
Summary: My fake data was 100%, and not all tables have full revision history. This leads to a broken table. Instead check if we have //any// revisions at all, then always show the column, with or without a link inside.

Test Plan: going on a limb this is the correct fix and test on secure... again ...

Reviewers: epriestley

Reviewed By: epriestley

Spies: Korvin

Differential Revision: https://secure.phabricator.com/D18474
This commit is contained in:
Chad Little 2017-08-24 19:52:12 -07:00
parent 12ae08b6b1
commit 94cad30ac3
3 changed files with 7 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
resources/celerity/map.php
View file

@ -74,7 +74,7 @@ return array(
'rsrc/css/application/diffusion/diffusion-icons.css' => '0c15255e',
'rsrc/css/application/diffusion/diffusion-readme.css' => '419dd5b6',
'rsrc/css/application/diffusion/diffusion-repository.css' => 'ee6f20ec',
'rsrc/css/application/diffusion/diffusion-source.css' => 'cb2bf02e',
'rsrc/css/application/diffusion/diffusion-source.css' => '47db8a7c',
'rsrc/css/application/diffusion/diffusion.css' => 'ceacf994',
'rsrc/css/application/feed/feed.css' => 'ecd4ec57',
'rsrc/css/application/files/global-drag-and-drop.css' => 'b556a948',
@ -574,7 +574,7 @@ return array(
'diffusion-icons-css' => '0c15255e',
'diffusion-readme-css' => '419dd5b6',
'diffusion-repository-css' => 'ee6f20ec',
'diffusion-source-css' => 'cb2bf02e',
'diffusion-source-css' => '47db8a7c',
'diviner-shared-css' => '896f1d43',
'font-fontawesome' => 'e838e088',
'font-lato' => 'c7ccd872',

2
src/applications/diffusion/controller/DiffusionBrowseController.php
View file

@ -1183,7 +1183,7 @@ final class DiffusionBrowseController extends DiffusionController {
),
$commit_link);
if ($revision_link) {
if ($revision_map) {
$row[] = phutil_tag(
'th',
array(

14
webroot/rsrc/css/application/diffusion/diffusion-source.css
View file

@ -37,24 +37,18 @@
white-space: nowrap;
}
.diffusion-blame-date {
.diffusion-blame-date,
.diffusion-blame-link,
.diffusion-blame-revision,
.diffusion-rev-link {
background: {$lightgreybackground};
font: {$basefont};
font-size: {$smallerfontsize};
}
.diffusion-blame-link,
.diffusion-line-link,
.diffusion-blame-revision {
background: {$lightgreybackground};
}
.diffusion-source th.diffusion-rev-link {
text-align: left;
min-width: 130px;
background: {$lightgreybackground};
font: {$basefont};
font-size: {$smallerfontsize};
}
.diffusion-source a {