revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 00:32:42 +01:00
Code Issues Releases Wiki Activity

Fix PHP 8.1 "ltrim(null)" exception which blocks adding additional user email address

Browse source 
Summary:
Since PHP 8.1, passing a null string to `ltrim(string $string)` is deprecated.

Thus we make sure that `$request->getStr('email')` does not return null as default.

Closes T15376

Test Plan: Applied this change, afterwards repeated the steps to add a new email address on `/settings/panel/email/`. This time, it's possible to close the "Verification Email Sent" and the page `/settings/panel/email/` renders and lists the new email address.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15376

Differential Revision: https://we.phorge.it/D25210
This commit is contained in:
Valerio Bozzolan 2023-05-20 14:27:06 +02:00 committed by Andre Klapper
parent 1b905706b4
commit 94d45de2f7
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/settings/panel/PhabricatorEmailAddressesSettingsPanel.php
View file

@ -172,7 +172,7 @@ final class PhabricatorEmailAddressesSettingsPanel
$email = null;
$errors = array();
if ($request->isDialogFormPost()) {
$email = trim($request->getStr('email'));
$email = trim($request->getStr('email', ''));
if ($new == 'verify') {
// The user clicked "Done" from the "an email has been sent" dialog.