From 94da7c20335f33e5386a2970dbbee58ac360611c Mon Sep 17 00:00:00 2001 From: epriestley Date: Fri, 25 Jan 2013 08:13:08 -0800 Subject: [PATCH] Restore string cast for textarea control Summary: Removed in 48561a8b but actually necessary. Test Plan: Differential now renders textareas correctly. Reviewers: vrana Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D4643 --- src/view/form/control/AphrontFormTextAreaControl.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/view/form/control/AphrontFormTextAreaControl.php b/src/view/form/control/AphrontFormTextAreaControl.php index 311beaea8e..bd36122ee9 100644 --- a/src/view/form/control/AphrontFormTextAreaControl.php +++ b/src/view/form/control/AphrontFormTextAreaControl.php @@ -72,7 +72,9 @@ class AphrontFormTextAreaControl extends AphrontFormControl { 'id' => $this->getID(), 'placeholder' => $this->getPlaceHolder(), ), - $this->getValue()); + // NOTE: This needs to be string cast, because if we pass `null` the + // tag will be self-closed and some browsers aren't thrilled about that. + (string)$this->getValue()); } }