From 95925ad58ffb66a77384fcc2d34ed88e7a2a1cbd Mon Sep 17 00:00:00 2001 From: epriestley Date: Sun, 14 May 2017 13:35:54 -0700 Subject: [PATCH] Make getApplicationTransactionEditor() in PhabricatorApplication return an editor Summary: Ref T12685. I provided this incorrect (`return new` rather than `throw`) implementation earlier; it can now be replaced with a proper implementation. This caused application policy edits to spew this into the daemon log: ``` [2017-05-14 15:35:27] EXCEPTION: (Error) Call to undefined method PhutilMethodNotImplementedException::setActor() at [/src/applications/transactions/worker/PhabricatorApplicationTransactionPublishWorker.php:69] ``` Test Plan: - Used `bin/worker execute --id ` to execute a previously-failing task. - Saw a feed story publish. Reviewers: chad, amckinley Reviewed By: chad Maniphest Tasks: T12685 Differential Revision: https://secure.phabricator.com/D17876 --- src/applications/base/PhabricatorApplication.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/base/PhabricatorApplication.php b/src/applications/base/PhabricatorApplication.php index af683e0592..f525d0ec97 100644 --- a/src/applications/base/PhabricatorApplication.php +++ b/src/applications/base/PhabricatorApplication.php @@ -642,7 +642,7 @@ abstract class PhabricatorApplication public function getApplicationTransactionEditor() { - return new PhutilMethodNotImplementedException(pht('Coming Soon!')); + return new PhabricatorApplicationEditor(); } public function getApplicationTransactionObject() {