Make objects implementing BuildableInterface produce a BuildableEngine

Summary:
Ref T13110. Currently, build status is published the same way for every Buildable by the BuildEngine.

I want to change this to delegate publishing to each Buildable, particularly so that Differential may use more detailed rules for handling builds and drafts.

Rather than add additional methods to the existing `BuildableInterface`, add an engine generator method instead. This is a pattern which has seen more use recently (e.g., in Ferret) and lets us pay a little more upfront to pull complex pieces of logic out of the main class and let them use inheritence more easily. If we had Traits that might cover this to some degree.

I'd expect to eventually reduce the size of `BuildableInterface` and move the `CircleCI` and `BuildKite` interfaces so that the `BuildableEngine` implements them instead of the main object.

Here, this new engine does nothing and is never instantiated. In upcoming changes, publishing logic will move into it so that Differential can handle publishing differently.

Test Plan: Ran `arc liberate`, loaded pages, grepped for `BuildableInterface`.

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T13110

Differential Revision: https://secure.phabricator.com/D19278

src/__phutil_library_map__.php

@@ -380,6 +380,7 @@ phutil_register_library_map(array(
     'DifferentialBlockHeraldAction' => 'applications/differential/herald/DifferentialBlockHeraldAction.php',
     'DifferentialBlockingReviewerDatasource' => 'applications/differential/typeahead/DifferentialBlockingReviewerDatasource.php',
     'DifferentialBranchField' => 'applications/differential/customfield/DifferentialBranchField.php',
+    'DifferentialBuildableEngine' => 'applications/differential/harbormaster/DifferentialBuildableEngine.php',
     'DifferentialChangeDetailMailView' => 'applications/differential/mail/DifferentialChangeDetailMailView.php',
     'DifferentialChangeHeraldFieldGroup' => 'applications/differential/herald/DifferentialChangeHeraldFieldGroup.php',
     'DifferentialChangeType' => 'applications/differential/constants/DifferentialChangeType.php',
@@ -638,6 +639,7 @@ phutil_register_library_map(array(
     'DiffusionBrowseQueryConduitAPIMethod' => 'applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php',
     'DiffusionBrowseResultSet' => 'applications/diffusion/data/DiffusionBrowseResultSet.php',
     'DiffusionBrowseTableView' => 'applications/diffusion/view/DiffusionBrowseTableView.php',
+    'DiffusionBuildableEngine' => 'applications/diffusion/harbormaster/DiffusionBuildableEngine.php',
     'DiffusionCacheEngineExtension' => 'applications/diffusion/engineextension/DiffusionCacheEngineExtension.php',
     'DiffusionCachedResolveRefsQuery' => 'applications/diffusion/query/DiffusionCachedResolveRefsQuery.php',
     'DiffusionChangeController' => 'applications/diffusion/controller/DiffusionChangeController.php',
@@ -1285,6 +1287,7 @@ phutil_register_library_map(array(
     'HarbormasterBuildable' => 'applications/harbormaster/storage/HarbormasterBuildable.php',
     'HarbormasterBuildableActionController' => 'applications/harbormaster/controller/HarbormasterBuildableActionController.php',
     'HarbormasterBuildableAdapterInterface' => 'applications/harbormaster/herald/HarbormasterBuildableAdapterInterface.php',
+    'HarbormasterBuildableEngine' => 'applications/harbormaster/engine/HarbormasterBuildableEngine.php',
     'HarbormasterBuildableInterface' => 'applications/harbormaster/interface/HarbormasterBuildableInterface.php',
     'HarbormasterBuildableListController' => 'applications/harbormaster/controller/HarbormasterBuildableListController.php',
     'HarbormasterBuildablePHIDType' => 'applications/harbormaster/phid/HarbormasterBuildablePHIDType.php',
@@ -5586,6 +5589,7 @@ phutil_register_library_map(array(
     'DifferentialBlockHeraldAction' => 'HeraldAction',
     'DifferentialBlockingReviewerDatasource' => 'PhabricatorTypeaheadCompositeDatasource',
     'DifferentialBranchField' => 'DifferentialCustomField',
+    'DifferentialBuildableEngine' => 'HarbormasterBuildableEngine',
     'DifferentialChangeDetailMailView' => 'DifferentialMailView',
     'DifferentialChangeHeraldFieldGroup' => 'HeraldFieldGroup',
     'DifferentialChangeType' => 'Phobject',
@@ -5883,6 +5887,7 @@ phutil_register_library_map(array(
     'DiffusionBrowseQueryConduitAPIMethod' => 'DiffusionQueryConduitAPIMethod',
     'DiffusionBrowseResultSet' => 'Phobject',
     'DiffusionBrowseTableView' => 'DiffusionView',
+    'DiffusionBuildableEngine' => 'HarbormasterBuildableEngine',
     'DiffusionCacheEngineExtension' => 'PhabricatorCacheEngineExtension',
     'DiffusionCachedResolveRefsQuery' => 'DiffusionLowLevelQuery',
     'DiffusionChangeController' => 'DiffusionController',
@@ -6636,6 +6641,7 @@ phutil_register_library_map(array(
       'PhabricatorDestructibleInterface',
     ),
     'HarbormasterBuildableActionController' => 'HarbormasterController',
+    'HarbormasterBuildableEngine' => 'Phobject',
     'HarbormasterBuildableListController' => 'HarbormasterController',
     'HarbormasterBuildablePHIDType' => 'PhabricatorPHIDType',
     'HarbormasterBuildableQuery' => 'PhabricatorCursorPagedPolicyAwareQuery',

src/applications/differential/harbormaster/DifferentialBuildableEngine.php

@@ -0,0 +1,4 @@
+<?php
+
+final class DifferentialBuildableEngine
+  extends HarbormasterBuildableEngine {}

src/applications/differential/storage/DifferentialDiff.php

@@ -557,6 +557,10 @@ final class DifferentialDiff
     );
   }
 
+  public function newBuildableEngine() {
+    return new DifferentialBuildableEngine();
+  }
+
 
 /* -(  HarbormasterCircleCIBuildableInterface  )----------------------------- */
 

src/applications/differential/storage/DifferentialRevision.php

@@ -800,6 +800,10 @@ final class DifferentialRevision extends DifferentialDAO
     return array();
   }
 
+  public function newBuildableEngine() {
+    return new DifferentialBuildableEngine();
+  }
+
 
 /* -(  PhabricatorSubscribableInterface  )----------------------------------- */
 

src/applications/diffusion/harbormaster/DiffusionBuildableEngine.php

@@ -0,0 +1,4 @@
+<?php
+
+final class DiffusionBuildableEngine
+  extends HarbormasterBuildableEngine {}

src/applications/harbormaster/engine/HarbormasterBuildableEngine.php

@@ -0,0 +1,4 @@
+<?php
+
+abstract class HarbormasterBuildableEngine
+  extends Phobject {}

src/applications/harbormaster/interface/HarbormasterBuildableInterface.php

@@ -36,4 +36,6 @@ interface HarbormasterBuildableInterface {
   public function getBuildVariables();
   public function getAvailableBuildVariables();
 
+  public function newBuildableEngine();
+
 }

src/applications/harbormaster/storage/HarbormasterBuildable.php

@@ -341,6 +341,10 @@ final class HarbormasterBuildable
     return array();
   }
 
+  public function newBuildableEngine() {
+    return $this->getBuildableObject()->newBuildableEngine();
+  }
+
 
 /* -(  PhabricatorDestructibleInterface  )----------------------------------- */
 

src/applications/repository/storage/PhabricatorRepositoryCommit.php

@@ -549,6 +549,10 @@ final class PhabricatorRepositoryCommit
     );
   }
 
+  public function newBuildableEngine() {
+    return new DiffusionBuildableEngine();
+  }
+
 
 /* -(  HarbormasterCircleCIBuildableInterface  )----------------------------- */