diff --git a/src/applications/maniphest/view/ManiphestTransactionDetailView.php b/src/applications/maniphest/view/ManiphestTransactionDetailView.php index 99d5aac688..4d5afbf8ad 100644 --- a/src/applications/maniphest/view/ManiphestTransactionDetailView.php +++ b/src/applications/maniphest/view/ManiphestTransactionDetailView.php @@ -164,12 +164,18 @@ final class ManiphestTransactionDetailView extends ManiphestView { if ($this->getRenderFullSummary()) { $full_summary = $this->renderFullSummary($transaction); } - $descs[] = javelin_render_tag( + $descs[] = javelin_tag( 'div', array( 'sigil' => 'maniphest-transaction-description', ), - $author->renderLink().' '.$desc.'.'.$full_summary); + array( + $author->renderLink(), + ' ', + $desc, + '.', + $full_summary, + )); } if ($this->getRenderSummaryOnly()) { @@ -551,6 +557,11 @@ final class ManiphestTransactionDetailView extends ManiphestView { return array($type, ' brazenly '.$type."'d", $classes); } + // TODO: [HTML] This code will all be rewritten when we switch to using + // ApplicationTransactions. It does not handle HTML or translations + // correctly right now. + $desc = phutil_safe_html($desc); + return array($verb, $desc, $classes); } @@ -579,6 +590,9 @@ final class ManiphestTransactionDetailView extends ManiphestView { DifferentialChangesetParser::parseRangeSpecification($spec); $output = $parser->render($range_s, $range_e, $mask); + // TODO: [HTML] DifferentialChangesetParser needs cleanup. + $output = phutil_safe_html($output); + return $output; } diff --git a/src/view/layout/PhabricatorCrumbsView.php b/src/view/layout/PhabricatorCrumbsView.php index 0ac55bb46f..f621394f1e 100644 --- a/src/view/layout/PhabricatorCrumbsView.php +++ b/src/view/layout/PhabricatorCrumbsView.php @@ -50,26 +50,29 @@ final class PhabricatorCrumbsView extends AphrontView { )); } - $action_view = phutil_render_tag( + $action_view = phutil_tag( 'div', array( 'class' => 'phabricator-crumbs-actions', ), - self::renderSingleView($actions)); + $this->renderHTMLView($actions)); } if ($this->crumbs) { last($this->crumbs)->setIsLastCrumb(true); } - return phutil_render_tag( + return phutil_tag( 'div', array( 'class' => 'phabricator-crumbs-view '. 'sprite-gradient gradient-breadcrumbs', ), - $action_view. - self::renderSingleView($this->crumbs)); + $this->renderHTMLView( + array( + $action_view, + $this->crumbs, + ))); } }