From 95feb31fbfa03374bcd86d91a2ac7b1ae62712c8 Mon Sep 17 00:00:00 2001 From: vrana Date: Fri, 10 Feb 2012 22:43:13 -0800 Subject: [PATCH] Whitespace parameter on Show Raw File is useless Test Plan: Show Raw File Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1600 --- .../DifferentialChangesetListView.php | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/applications/differential/view/changesetlistview/DifferentialChangesetListView.php b/src/applications/differential/view/changesetlistview/DifferentialChangesetListView.php index 4f149e3f70..4fb8b0ca11 100644 --- a/src/applications/differential/view/changesetlistview/DifferentialChangesetListView.php +++ b/src/applications/differential/view/changesetlistview/DifferentialChangesetListView.php @@ -123,11 +123,7 @@ class DifferentialChangesetListView extends AphrontView { $detail_button = null; if ($this->standaloneViews) { $detail_uri = new PhutilURI($this->renderURI); - $detail_uri->setQueryParams( - array( - 'ref' => $ref, - 'whitespace' => $this->whitespace, - )); + $detail_uri->setQueryParams(array('ref' => $ref)); $diffusion_uri = null; if ($repository) { @@ -136,7 +132,8 @@ class DifferentialChangesetListView extends AphrontView { } $meta = array( - 'detailURI' => (string)$detail_uri, + 'detailURI' => + (string)$detail_uri->alter('whitespace', $this->whitespace), 'diffusionURI' => $diffusion_uri, 'containerID' => $detail->getID(), ); @@ -167,7 +164,7 @@ class DifferentialChangesetListView extends AphrontView { array( 'class' => 'button small grey', 'meta' => $meta, - 'href' => $detail_uri, + 'href' => $meta['detailURI'], 'target' => '_blank', 'sigil' => 'differential-view-options', ),