revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-08 22:01:03 +01:00
Code Issues Releases Wiki Activity

Don't require "CAN_EDIT" to watch/unwatch a project

Browse source 
Summary:
See T1024. When "CAN_EDIT" became default in T13186, this was missed as an exception.

Watching shouldn't require "CAN_EDIT", so exempt it.

Test Plan:
  - Before change: tried to watch a project I could not edit, got a policy error.
  - After change: watched/unwatched a project I could not edit.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D19977
This commit is contained in:
epriestley 2019-01-16 05:51:59 -08:00
parent 64e3296fe6
commit 966a93334c
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
View file

@ -1677,6 +1677,9 @@ abstract class PhabricatorApplicationTransactionEditor
// You need CAN_EDIT to change members other than yourself. // You need CAN_EDIT to change members other than yourself.
return PhabricatorPolicyCapability::CAN_EDIT; return PhabricatorPolicyCapability::CAN_EDIT;
case PhabricatorObjectHasWatcherEdgeType::EDGECONST:
// See PHI1024. Watching a project does not require CAN_EDIT.
return null;
default: default:
return PhabricatorPolicyCapability::CAN_EDIT; return PhabricatorPolicyCapability::CAN_EDIT;
} }