Fail feed story renders individually, instead of in aggregate

Summary: When we fail to render a feed story because something is broken, just break that story, not the entire feed.

Test Plan: {F125898}

Reviewers: btrahan, chad

Reviewed By: chad

CC: aran

Differential Revision: https://secure.phabricator.com/D8488

src/applications/feed/builder/PhabricatorFeedBuilder.php

@@ -57,8 +57,21 @@ final class PhabricatorFeedBuilder {
         $null_view->appendChild($header);
       }
 
-      $view = $story->renderView();
+      try {
-      $view->setUser($user);
+        $view = $story->renderView();
+        $view->setUser($user);
+        $view = $view->render();
+      } catch (Exception $ex) {
+        // If rendering failed for any reason, don't fail the entire feed,
+        // just this one story.
+        $view = id(new PHUIFeedStoryView())
+          ->setUser($user)
+          ->setChronologicalKey($story->getChronologicalKey())
+          ->setEpoch($story->getEpoch())
+          ->setTitle(
+            pht('Feed Story Failed to Render (%s)', get_class($story)))
+          ->appendChild(pht('%s: %s', get_class($ex), $ex->getMessage()));
+      }
 
       $null_view->appendChild($view);
     }