From 969d3be035eda9d887b84ae886dcf9162a611578 Mon Sep 17 00:00:00 2001 From: Chad Little Date: Fri, 20 May 2016 13:03:26 -0700 Subject: [PATCH] Clean up "points" display on workboards Summary: Couple of edge cases here I never cleaned up. This inlines points and projects better, with spacing and use of grey to better differentate from project tag colors. Test Plan: Review edge cases on workboard with multiple short and long project names. {F1653998} {F1653999} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15956 --- resources/celerity/map.php | 4 ++-- .../project/view/ProjectBoardTaskCard.php | 5 +++-- webroot/rsrc/css/phui/workboards/phui-workcard.css | 13 +++++++++++++ 3 files changed, 18 insertions(+), 4 deletions(-) diff --git a/resources/celerity/map.php b/resources/celerity/map.php index e8a47add63..afd12fbfff 100644 --- a/resources/celerity/map.php +++ b/resources/celerity/map.php @@ -159,7 +159,7 @@ return array( 'rsrc/css/phui/phui-two-column-view.css' => 'b9538af1', 'rsrc/css/phui/workboards/phui-workboard-color.css' => 'ac6fe6a7', 'rsrc/css/phui/workboards/phui-workboard.css' => 'e6d89647', - 'rsrc/css/phui/workboards/phui-workcard.css' => '3646fb96', + 'rsrc/css/phui/workboards/phui-workcard.css' => '0c62d7c5', 'rsrc/css/phui/workboards/phui-workpanel.css' => '92197373', 'rsrc/css/sprite-login.css' => '60e8560e', 'rsrc/css/sprite-menu.css' => '9dd65b92', @@ -858,7 +858,7 @@ return array( 'phui-two-column-view-css' => 'b9538af1', 'phui-workboard-color-css' => 'ac6fe6a7', 'phui-workboard-view-css' => 'e6d89647', - 'phui-workcard-view-css' => '3646fb96', + 'phui-workcard-view-css' => '0c62d7c5', 'phui-workpanel-view-css' => '92197373', 'phuix-action-list-view' => 'b5c256b8', 'phuix-action-view' => '8cf6d262', diff --git a/src/applications/project/view/ProjectBoardTaskCard.php b/src/applications/project/view/ProjectBoardTaskCard.php index 7be0af2c2f..a7ee93dd76 100644 --- a/src/applications/project/view/ProjectBoardTaskCard.php +++ b/src/applications/project/view/ProjectBoardTaskCard.php @@ -100,9 +100,10 @@ final class ProjectBoardTaskCard extends Phobject { if ($points !== null) { $points_tag = id(new PHUITagView()) ->setType(PHUITagView::TYPE_SHADE) - ->setShade(PHUITagView::COLOR_BLUE) + ->setShade(PHUITagView::COLOR_GREY) ->setSlimShady(true) - ->setName($points); + ->setName($points) + ->addClass('phui-workcard-points'); $card->addAttribute($points_tag); } } diff --git a/webroot/rsrc/css/phui/workboards/phui-workcard.css b/webroot/rsrc/css/phui/workboards/phui-workcard.css index f3d92d63e5..64792c6915 100644 --- a/webroot/rsrc/css/phui/workboards/phui-workcard.css +++ b/webroot/rsrc/css/phui/workboards/phui-workcard.css @@ -114,6 +114,19 @@ margin-bottom: 0; } +.phui-workcard .phui-object-item-attribute-spacer { + display: none; +} + +.phui-workcard .phui-workcard-points { + margin: 0 4px 2px 0; + display: inline-block; +} + +.phui-workcard .phui-object-item-attribute { + display: inline; +} + /* - Draggable Colors --------------------------------------------------------*/