revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-18 19:40:55 +01:00
Code Issues Releases Wiki Activity

Bring up contrast on light green / red diffs

Browse source 
Summary: Minor color saturation here, ideal for low quality monitors.

Test Plan:
Review new colors in various scenarios.

{F2305178}

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D17141
This commit is contained in:
Chad Little 2017-01-04 15:05:04 -08:00
parent 2855470b31
commit 96fbf37dcc
4 changed files with 34 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
resources/celerity/map.php
View file

@ -12,7 +12,7 @@ return array(
'core.pkg.css' => '9c725fa0',
'core.pkg.js' => 'f998932d',
'darkconsole.pkg.js' => 'e7393ebb',
'differential.pkg.css' => '13726e1c',
'differential.pkg.css' => 'f69afb45',
'differential.pkg.js' => '40b18f35',
'diffusion.pkg.css' => '91c5d3a6',
'diffusion.pkg.js' => '84c8f8fd',
@ -59,7 +59,7 @@ return array(
'rsrc/css/application/dashboard/dashboard.css' => 'bc6f2127',
'rsrc/css/application/diff/inline-comment-summary.css' => '51efda3a',
'rsrc/css/application/differential/add-comment.css' => 'c47f8c40',
'rsrc/css/application/differential/changeset-view.css' => '6d0fc277',
'rsrc/css/application/differential/changeset-view.css' => '11395d9c',
'rsrc/css/application/differential/core.css' => '5b7b8ff4',
'rsrc/css/application/differential/phui-inline-comment.css' => '5953c28e',
'rsrc/css/application/differential/revision-comment.css' => '14b8565a',
@ -574,7 +574,7 @@ return array(
'conpherence-thread-manager' => 'c8b5ee6f',
'conpherence-transaction-css' => '85129c68',
'd3' => 'a11a5ff2',
'differential-changeset-view-css' => '6d0fc277',
'differential-changeset-view-css' => '11395d9c',
'differential-core-view-css' => '5b7b8ff4',
'differential-inline-comment-editor' => '2e3f9738',
'differential-revision-add-comment-css' => 'c47f8c40',
@ -1032,6 +1032,9 @@ return array(
'javelin-dom',
'javelin-typeahead-normalizer',
),
'11395d9c' => array(
'phui-inline-comment-view-css',
),
'12884df9' => array(
'javelin-behavior',
'javelin-stratcom',
@ -1455,9 +1458,6 @@ return array(
'javelin-install',
'javelin-util',
),
'6d0fc277' => array(
'phui-inline-comment-view-css',
),
'6d3e1947' => array(
'javelin-behavior',
'javelin-diffusion-locate-file-source',

20
src/applications/differential/render/DifferentialChangesetOneUpRenderer.php
View file

@ -97,16 +97,22 @@ final class DifferentialChangesetOneUpRenderer
$line = array($hidden, $line);
}
$cells[] = phutil_tag('th', array('id' => $left_id), $line);
$cells[] = phutil_tag(
'th',
array(
'id' => $left_id,
'class' => $class,
),
$line);
$cells[] = phutil_tag('th', array());
$cells[] = phutil_tag('th', array('class' => $class));
$cells[] = $no_copy;
$cells[] = phutil_tag('td', array('class' => $class), $p['render']);
$cells[] = $no_coverage;
} else {
if ($p['htype']) {
$class = 'right new';
$cells[] = phutil_tag('th', array());
$cells[] = phutil_tag('th', array('class' => $class));
} else {
$class = 'right';
if ($left_prefix) {
@ -138,7 +144,13 @@ final class DifferentialChangesetOneUpRenderer
$line = array($hidden, $line);
}
$cells[] = phutil_tag('th', array('id' => $right_id), $line);
$cells[] = phutil_tag(
'th',
array(
'id' => $right_id,
'class' => $class,
),
$line);
$cells[] = $no_copy;
$cells[] = phutil_tag('td', array('class' => $class), $p['render']);

4
src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php
View file

@ -306,9 +306,9 @@ final class DifferentialChangesetTwoUpRenderer
$zero_space = "\xE2\x80\x8B";
$html[] = phutil_tag('tr', array(), array(
phutil_tag('th', array('id' => $o_id), $o_num),
phutil_tag('th', array('id' => $o_id, 'class' => $o_classes), $o_num),
phutil_tag('td', array('class' => $o_classes), $o_text),
phutil_tag('th', array('id' => $n_id), $n_num),
phutil_tag('th', array('id' => $n_id, 'class' => $n_classes), $n_num),
$n_copy,
phutil_tag(
'td',

10
webroot/rsrc/css/application/differential/changeset-view.css
View file

@ -121,6 +121,16 @@
cursor: auto;
}
.differential-diff th.old {
background: #ffdddd;
border-right-color: #f8cbcb;
}
.differential-diff th.new {
background: #dbffdb;
border-right-color: #a6f3a6;
}
.differential-diff td.old,
.differential-diff td.old-full {
background: #ffecec;