mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-28 08:20:57 +01:00
Add "overflow: auto" to all comment boxes
Summary: Set these all to "overflow: auto". Test Plan: Made comments like "MMMMMMM..." in: - Differential comment preview. - Differential comment (saved). - Maniphest comment preview. - Maniphest comment (saved). - Differential inline comment draft. - Differential inline comment preview. - Differential inline comment (saved). Also tested code blocks. Reviewers: nh, btrahan, jungejason Reviewed By: jungejason CC: aran, epriestley Maniphest Tasks: T883 Differential Revision: https://secure.phabricator.com/D1641
This commit is contained in:
parent
c8b9418ebc
commit
9748520b0e
4 changed files with 40 additions and 36 deletions
|
@ -213,7 +213,7 @@ celerity_register_resource_map(array(
|
||||||
),
|
),
|
||||||
'differential-revision-comment-css' =>
|
'differential-revision-comment-css' =>
|
||||||
array(
|
array(
|
||||||
'uri' => '/res/be9a95b4/rsrc/css/application/differential/revision-comment.css',
|
'uri' => '/res/85efa17a/rsrc/css/application/differential/revision-comment.css',
|
||||||
'type' => 'css',
|
'type' => 'css',
|
||||||
'requires' =>
|
'requires' =>
|
||||||
array(
|
array(
|
||||||
|
@ -1272,7 +1272,7 @@ celerity_register_resource_map(array(
|
||||||
),
|
),
|
||||||
'maniphest-transaction-detail-css' =>
|
'maniphest-transaction-detail-css' =>
|
||||||
array(
|
array(
|
||||||
'uri' => '/res/552bb734/rsrc/css/application/maniphest/transaction-detail.css',
|
'uri' => '/res/4083354f/rsrc/css/application/maniphest/transaction-detail.css',
|
||||||
'type' => 'css',
|
'type' => 'css',
|
||||||
'requires' =>
|
'requires' =>
|
||||||
array(
|
array(
|
||||||
|
@ -1776,23 +1776,7 @@ celerity_register_resource_map(array(
|
||||||
'uri' => '/res/pkg/46547a92/core.pkg.js',
|
'uri' => '/res/pkg/46547a92/core.pkg.js',
|
||||||
'type' => 'js',
|
'type' => 'js',
|
||||||
),
|
),
|
||||||
'540effd7' =>
|
'4c3b1b11' =>
|
||||||
array(
|
|
||||||
'name' => 'typeahead.pkg.js',
|
|
||||||
'symbols' =>
|
|
||||||
array(
|
|
||||||
0 => 'javelin-typeahead',
|
|
||||||
1 => 'javelin-typeahead-normalizer',
|
|
||||||
2 => 'javelin-typeahead-source',
|
|
||||||
3 => 'javelin-typeahead-preloaded-source',
|
|
||||||
4 => 'javelin-typeahead-ondemand-source',
|
|
||||||
5 => 'javelin-tokenizer',
|
|
||||||
6 => 'javelin-behavior-aphront-basic-tokenizer',
|
|
||||||
),
|
|
||||||
'uri' => '/res/pkg/540effd7/typeahead.pkg.js',
|
|
||||||
'type' => 'js',
|
|
||||||
),
|
|
||||||
'80580cea' =>
|
|
||||||
array(
|
array(
|
||||||
'name' => 'differential.pkg.css',
|
'name' => 'differential.pkg.css',
|
||||||
'symbols' =>
|
'symbols' =>
|
||||||
|
@ -1810,9 +1794,25 @@ celerity_register_resource_map(array(
|
||||||
10 => 'phabricator-content-source-view-css',
|
10 => 'phabricator-content-source-view-css',
|
||||||
11 => 'differential-local-commits-view-css',
|
11 => 'differential-local-commits-view-css',
|
||||||
),
|
),
|
||||||
'uri' => '/res/pkg/80580cea/differential.pkg.css',
|
'uri' => '/res/pkg/4c3b1b11/differential.pkg.css',
|
||||||
'type' => 'css',
|
'type' => 'css',
|
||||||
),
|
),
|
||||||
|
'540effd7' =>
|
||||||
|
array(
|
||||||
|
'name' => 'typeahead.pkg.js',
|
||||||
|
'symbols' =>
|
||||||
|
array(
|
||||||
|
0 => 'javelin-typeahead',
|
||||||
|
1 => 'javelin-typeahead-normalizer',
|
||||||
|
2 => 'javelin-typeahead-source',
|
||||||
|
3 => 'javelin-typeahead-preloaded-source',
|
||||||
|
4 => 'javelin-typeahead-ondemand-source',
|
||||||
|
5 => 'javelin-tokenizer',
|
||||||
|
6 => 'javelin-behavior-aphront-basic-tokenizer',
|
||||||
|
),
|
||||||
|
'uri' => '/res/pkg/540effd7/typeahead.pkg.js',
|
||||||
|
'type' => 'js',
|
||||||
|
),
|
||||||
'b164acea' =>
|
'b164acea' =>
|
||||||
array(
|
array(
|
||||||
'name' => 'javelin.pkg.js',
|
'name' => 'javelin.pkg.js',
|
||||||
|
@ -1886,23 +1886,23 @@ celerity_register_resource_map(array(
|
||||||
'aphront-crumbs-view-css' => 'da9f8734',
|
'aphront-crumbs-view-css' => 'da9f8734',
|
||||||
'aphront-dialog-view-css' => 'da9f8734',
|
'aphront-dialog-view-css' => 'da9f8734',
|
||||||
'aphront-form-view-css' => 'da9f8734',
|
'aphront-form-view-css' => 'da9f8734',
|
||||||
'aphront-headsup-action-list-view-css' => '80580cea',
|
'aphront-headsup-action-list-view-css' => '4c3b1b11',
|
||||||
'aphront-list-filter-view-css' => 'da9f8734',
|
'aphront-list-filter-view-css' => 'da9f8734',
|
||||||
'aphront-panel-view-css' => 'da9f8734',
|
'aphront-panel-view-css' => 'da9f8734',
|
||||||
'aphront-side-nav-view-css' => 'da9f8734',
|
'aphront-side-nav-view-css' => 'da9f8734',
|
||||||
'aphront-table-view-css' => 'da9f8734',
|
'aphront-table-view-css' => 'da9f8734',
|
||||||
'aphront-tokenizer-control-css' => 'da9f8734',
|
'aphront-tokenizer-control-css' => 'da9f8734',
|
||||||
'aphront-typeahead-control-css' => 'da9f8734',
|
'aphront-typeahead-control-css' => 'da9f8734',
|
||||||
'differential-changeset-view-css' => '80580cea',
|
'differential-changeset-view-css' => '4c3b1b11',
|
||||||
'differential-core-view-css' => '80580cea',
|
'differential-core-view-css' => '4c3b1b11',
|
||||||
'differential-inline-comment-editor' => 'ef420ead',
|
'differential-inline-comment-editor' => 'ef420ead',
|
||||||
'differential-local-commits-view-css' => '80580cea',
|
'differential-local-commits-view-css' => '4c3b1b11',
|
||||||
'differential-revision-add-comment-css' => '80580cea',
|
'differential-revision-add-comment-css' => '4c3b1b11',
|
||||||
'differential-revision-comment-css' => '80580cea',
|
'differential-revision-comment-css' => '4c3b1b11',
|
||||||
'differential-revision-comment-list-css' => '80580cea',
|
'differential-revision-comment-list-css' => '4c3b1b11',
|
||||||
'differential-revision-detail-css' => '80580cea',
|
'differential-revision-detail-css' => '4c3b1b11',
|
||||||
'differential-revision-history-css' => '80580cea',
|
'differential-revision-history-css' => '4c3b1b11',
|
||||||
'differential-table-of-contents-css' => '80580cea',
|
'differential-table-of-contents-css' => '4c3b1b11',
|
||||||
'diffusion-commit-view-css' => '03ef179e',
|
'diffusion-commit-view-css' => '03ef179e',
|
||||||
'javelin-behavior' => 'b164acea',
|
'javelin-behavior' => 'b164acea',
|
||||||
'javelin-behavior-aphront-basic-tokenizer' => '540effd7',
|
'javelin-behavior-aphront-basic-tokenizer' => '540effd7',
|
||||||
|
@ -1940,14 +1940,14 @@ celerity_register_resource_map(array(
|
||||||
'javelin-util' => 'b164acea',
|
'javelin-util' => 'b164acea',
|
||||||
'javelin-vector' => 'b164acea',
|
'javelin-vector' => 'b164acea',
|
||||||
'javelin-workflow' => '46547a92',
|
'javelin-workflow' => '46547a92',
|
||||||
'phabricator-content-source-view-css' => '80580cea',
|
'phabricator-content-source-view-css' => '4c3b1b11',
|
||||||
'phabricator-core-buttons-css' => 'da9f8734',
|
'phabricator-core-buttons-css' => 'da9f8734',
|
||||||
'phabricator-core-css' => 'da9f8734',
|
'phabricator-core-css' => 'da9f8734',
|
||||||
'phabricator-directory-css' => 'da9f8734',
|
'phabricator-directory-css' => 'da9f8734',
|
||||||
'phabricator-drag-and-drop-file-upload' => 'ef420ead',
|
'phabricator-drag-and-drop-file-upload' => 'ef420ead',
|
||||||
'phabricator-keyboard-shortcut' => '46547a92',
|
'phabricator-keyboard-shortcut' => '46547a92',
|
||||||
'phabricator-keyboard-shortcut-manager' => '46547a92',
|
'phabricator-keyboard-shortcut-manager' => '46547a92',
|
||||||
'phabricator-object-selector-css' => '80580cea',
|
'phabricator-object-selector-css' => '4c3b1b11',
|
||||||
'phabricator-remarkup-css' => 'da9f8734',
|
'phabricator-remarkup-css' => 'da9f8734',
|
||||||
'phabricator-shaped-request' => 'ef420ead',
|
'phabricator-shaped-request' => 'ef420ead',
|
||||||
'phabricator-standard-page-view' => 'da9f8734',
|
'phabricator-standard-page-view' => 'da9f8734',
|
||||||
|
|
|
@ -218,8 +218,10 @@ final class DifferentialInlineCommentView extends AphrontView {
|
||||||
'<span class="differential-inline-comment-line">'.$line.'</span>'.
|
'<span class="differential-inline-comment-line">'.$line.'</span>'.
|
||||||
phutil_escape_html($author).
|
phutil_escape_html($author).
|
||||||
'</div>'.
|
'</div>'.
|
||||||
|
'<div class="differential-inline-comment-content">'.
|
||||||
'<div class="phabricator-remarkup">'.
|
'<div class="phabricator-remarkup">'.
|
||||||
$content.
|
$content.
|
||||||
|
'</div>'.
|
||||||
'</div>');
|
'</div>');
|
||||||
|
|
||||||
return $this->scaffoldMarkup($markup);
|
return $this->scaffoldMarkup($markup);
|
||||||
|
|
|
@ -84,10 +84,11 @@
|
||||||
line-height: 1.4em;
|
line-height: 1.4em;
|
||||||
margin: 0em;
|
margin: 0em;
|
||||||
padding: .3em 5px .4em 1.25em;
|
padding: .3em 5px .4em 1.25em;
|
||||||
|
overflow: auto;
|
||||||
}
|
}
|
||||||
|
|
||||||
.differential-comment-content {
|
.differential-inline-comment-content {
|
||||||
overflow: hidden;
|
overflow: auto;
|
||||||
}
|
}
|
||||||
|
|
||||||
.differential-comment-content .phabricator-remarkup .remarkup-code-block,
|
.differential-comment-content .phabricator-remarkup .remarkup-code-block,
|
||||||
|
|
|
@ -80,6 +80,7 @@
|
||||||
border-top: 1px solid #e6e6e6;
|
border-top: 1px solid #e6e6e6;
|
||||||
padding: 4px 1em;
|
padding: 4px 1em;
|
||||||
background: #fcfcfc;
|
background: #fcfcfc;
|
||||||
|
overflow: auto;
|
||||||
}
|
}
|
||||||
|
|
||||||
.maniphest-change-table {
|
.maniphest-change-table {
|
||||||
|
|
Loading…
Reference in a new issue