From 9757edb268aa3a0ced53a7697663ca083358b945 Mon Sep 17 00:00:00 2001 From: adonohue Date: Thu, 14 Apr 2011 15:10:51 -0700 Subject: [PATCH] Fix "Resign as Reviewer" to appear only when actually a Reviewer Summary: Is this an appropriate place to say "herp derp?" Test Plan: Check for Resign as Reviewer for the following table waiting for review | accepted | committed Am actually reviewer Am not reviewer but CC'ed Unrelated Reviewers: epriestley CC: Differential Revision: 140 --- .../revisionview/DifferentialRevisionViewController.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/differential/controller/revisionview/DifferentialRevisionViewController.php b/src/applications/differential/controller/revisionview/DifferentialRevisionViewController.php index 1075c35b15..4f4778375c 100644 --- a/src/applications/differential/controller/revisionview/DifferentialRevisionViewController.php +++ b/src/applications/differential/controller/revisionview/DifferentialRevisionViewController.php @@ -506,7 +506,7 @@ class DifferentialRevisionViewController extends DifferentialController { $actions[DifferentialAction::ACTION_ADDREVIEWERS] = true; - return array_keys($actions); + return array_keys(array_filter($actions)); } private function loadInlineComments(array $comments, array &$changesets) {