revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-29 10:12:41 +01:00
Code Issues Releases Wiki Activity

Show repository information (and use repository identities) in commit hovercards

Browse source 
Summary:
Ref T12164. Ref T13439. Commit hovercards don't currently show the repository. Although this is sometimes obvious from context, it isn't at other times and it's clearly useful/important.

Also, use identities to render author/committer information and show committer if the committer differs from the author.

Test Plan: {F6989595}

Maniphest Tasks: T13439, T12164

Differential Revision: https://secure.phabricator.com/D20881
This commit is contained in:
epriestley 2019-10-31 08:50:31 -07:00
parent bcf15abcd3
commit 97bed35085
1 changed files with 34 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

43
src/applications/diffusion/engineextension/DiffusionHovercardEngineExtension.php
View file

@ -26,20 +26,45 @@ final class DiffusionHovercardEngineExtension
$viewer = $this->getViewer(); $viewer = $this->getViewer();
$author_phid = $commit->getAuthorPHID(); $commit = id(new DiffusionCommitQuery())
if ($author_phid) { ->setViewer($viewer)
$author = $viewer->renderHandle($author_phid); ->needIdentities(true)
} else { ->needCommitData(true)
$commit_data = $commit->loadCommitData(); ->withPHIDs(array($commit->getPHID()))
$author = phutil_tag('em', array(), $commit_data->getAuthorName()); ->executeOne();
if (!$commit) {
return;
} }
$author_phid = $commit->getAuthorDisplayPHID();
$committer_phid = $commit->getCommitterDisplayPHID();
$repository_phid = $commit->getRepository()->getPHID();
$phids = array();
$phids[] = $author_phid;
$phids[] = $committer_phid;
$phids[] = $repository_phid;
$handles = $viewer->loadHandles($phids);
$hovercard->setTitle($handle->getName()); $hovercard->setTitle($handle->getName());
$hovercard->setDetail($commit->getSummary()); $hovercard->setDetail($commit->getSummary());
$hovercard->addField(pht('Author'), $author); $repository = $handles[$repository_phid]->renderLink();
$hovercard->addField(pht('Date'), $hovercard->addField(pht('Repository'), $repository);
phabricator_date($commit->getEpoch(), $viewer));
$author = $handles[$author_phid]->renderLink();
if ($author_phid) {
$hovercard->addField(pht('Author'), $author);
}
if ($committer_phid && ($committer_phid !== $author_phid)) {
$committer = $handles[$committer_phid]->renderLink();
$hovercard->addField(pht('Committer'), $committer);
}
$date = phabricator_date($commit->getEpoch(), $viewer);
$hovercard->addField(pht('Date'), $date);
if (!$commit->isAuditStatusNoAudit()) { if (!$commit->isAuditStatusNoAudit()) {
$status = $commit->getAuditStatusObject(); $status = $commit->getAuditStatusObject();