revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-02 03:32:42 +01:00
Code Issues Releases Wiki Activity

When the last rejecting reviewer resigns from a revision, return it to "Needs Review"

Browse source 
Summary:
Ref T13216. Fixes T12920. See PHI911. If you reject a revision and then resign from it, it stays in "Needs Revision".

There's some arguable motivation for this, but it's inconsistent with how "Accept" works (if the last accepting reviewer resigns, we kick you out of "Accepted"). Make it consistent.

Test Plan:
  - As the only reviewer: requested changes to a revision, then resigned.
  - Before: revision stays in "Needs Revision".
  - After: revision moves back to "Needs Review".

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13216, T12920

Differential Revision: https://secure.phabricator.com/D19840
This commit is contained in:
epriestley 2018-11-26 06:00:59 -08:00
parent 433a7321ff
commit 97e7ef0f01
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/applications/differential/editor/DifferentialTransactionEditor.php
View file

@ -451,6 +451,11 @@ final class DifferentialTransactionEditor
// conditions for acceptance. This usually happens after an accepting // conditions for acceptance. This usually happens after an accepting
// reviewer resigns or is removed. // reviewer resigns or is removed.
$new_status = DifferentialRevisionStatus::NEEDS_REVIEW; $new_status = DifferentialRevisionStatus::NEEDS_REVIEW;
} else if ($was_revision) {
// This revision was "Needs Revision", but no longer has any rejecting
// reviewers. This usually happens after the last rejecting reviewer
// resigns or is removed. Put the revision back in "Needs Review".
$new_status = DifferentialRevisionStatus::NEEDS_REVIEW;
} }
if ($new_status === null) { if ($new_status === null) {