1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-28 16:30:59 +01:00

Add HiDPI favicons

Summary: Fixes T5939. Specifically, 16, 32, and 64 bit pngs are in the .ico file. Apple icons are added to support non-Retina and Retina iPad and iPhone. Follows roughly Apple guidelines here: https://developer.apple.com/library/ios/documentation/AppleApplications/Reference/SafariWebContent/ConfiguringWebApplications/ConfiguringWebApplications.html

Test Plan:
Tested Chrome, Firefox on Mac. Much cleaner on Retina.

{F230715,size=full}

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T5939

Differential Revision: https://secure.phabricator.com/D10796
This commit is contained in:
Chad Little 2014-11-07 17:07:38 -08:00
parent 796428c810
commit 97f05d6ab8
11 changed files with 32 additions and 5 deletions

View file

@ -219,9 +219,15 @@ return array(
'rsrc/externals/raphael/g.raphael.js' => '40dde778',
'rsrc/externals/raphael/g.raphael.line.js' => '40da039e',
'rsrc/externals/raphael/raphael.js' => '51ee6b43',
'rsrc/favicons/apple-touch-icon-120x120.png' => '43742962',
'rsrc/favicons/apple-touch-icon-152x152.png' => '669eaec3',
'rsrc/favicons/apple-touch-icon-76x76.png' => 'ecdef672',
'rsrc/favicons/favicon-128.png' => '47cdff03',
'rsrc/favicons/favicon-16x16.png' => 'ee2523ac',
'rsrc/favicons/favicon-32x32.png' => 'b6a8150e',
'rsrc/favicons/favicon-96x96.png' => '8f7ea177',
'rsrc/image/BFCFDA.png' => 'd5ec91f4',
'rsrc/image/actions/edit.png' => '2fc41442',
'rsrc/image/apple-touch-icon.png' => '8458dda7',
'rsrc/image/avatar.png' => '3eb28cd9',
'rsrc/image/checker_dark.png' => 'd8e65881',
'rsrc/image/checker_light.png' => 'a0155918',

View file

@ -75,11 +75,30 @@ class PhabricatorBarePageView extends AphrontPageView {
'maximum-scale=1',
));
}
$icon_tag = phutil_tag(
$icon_tag_76 = phutil_tag(
'link',
array(
'rel' => 'apple-touch-icon',
'href' => celerity_get_resource_uri('/rsrc/image/apple-touch-icon.png'),
'href' => celerity_get_resource_uri(
'/rsrc/favicons/apple-touch-icon-76x76.png'),
));
$icon_tag_120 = phutil_tag(
'link',
array(
'rel' => 'apple-touch-icon',
'sizes' => '120x120',
'href' => celerity_get_resource_uri(
'/rsrc/favicons/apple-touch-icon-120x120.png'),
));
$icon_tag_152 = phutil_tag(
'link',
array(
'rel' => 'apple-touch-icon',
'sizes' => '152x152',
'href' => celerity_get_resource_uri(
'/rsrc/favicons/apple-touch-icon-152x152.png'),
));
$apple_tag = phutil_tag(
@ -100,9 +119,11 @@ class PhabricatorBarePageView extends AphrontPageView {
$developer = PhabricatorEnv::getEnvConfig('phabricator.developer-mode');
return hsprintf(
'%s%s%s%s%s%s',
'%s%s%s%s%s%s%s%s',
$viewport_tag,
$icon_tag,
$icon_tag_76,
$icon_tag_120,
$icon_tag_152,
$apple_tag,
$referrer_tag,
CelerityStaticResourceResponse::renderInlineScript(

Binary file not shown.

Before

Width:  |  Height:  |  Size: 894 B

After

Width:  |  Height:  |  Size: 34 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 9.2 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 15 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 5.4 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 3.4 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 566 B

Binary file not shown.

After

Width:  |  Height:  |  Size: 1 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 4.6 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 4.9 KiB