From 980293b707a0180757f7708fbea8042a5cb1dd1d Mon Sep 17 00:00:00 2001
From: Valerio Bozzolan <nsa+gitspam@succhia.cz>
Date: Fri, 9 Jun 2023 14:46:54 +0200
Subject: [PATCH] Mobile: hide unuseful "Persistent Chat" checkbox

Summary:
On mobile devices like tablets or toasters the "Persistent Chat"
floating widget is already hidden.

So, the related checkbox available from the top navigation bar
is just confusing on tablet and mobile devices / toasters, since
that nice checkbox does nothing there.

On mobile and tablet, this is the graphical change:

| Before   | After     |
|----------|-----------|
|{F281239} | {F281235} |

This change do not change anything for desktop devices.
So, on desktop, that checkbox is obviously still visible.

Closes T15240

Test Plan:
- test on tablet and below: now the checkbox should be not visible
- test on desktop: the checkbox should still be visible

Reviewers: O1 Blessed Committers, Cigaryno, bfs, speck

Reviewed By: O1 Blessed Committers, Cigaryno, bfs, speck

Subscribers: avivey, bfs, dcog, chris, speck, tobiaswiese, Matthew, Cigaryno

Maniphest Tasks: T15240

Differential Revision: https://we.phorge.it/D25120
---
 resources/celerity/map.php                                | 6 +++---
 webroot/rsrc/css/application/conpherence/notification.css | 5 +++++
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index ade1764cf3..84d27ab4aa 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -7,7 +7,7 @@
  */
 return array(
   'names' => array(
-    'conpherence.pkg.css' => '0e3cf785',
+    'conpherence.pkg.css' => '76ed87e3',
     'conpherence.pkg.js' => '020aebcf',
     'core.pkg.css' => '0cb47e9d',
     'core.pkg.js' => '2eeda9e0',
@@ -53,7 +53,7 @@ return array(
     'rsrc/css/application/conpherence/header-pane.css' => 'c9a3db8e',
     'rsrc/css/application/conpherence/menu.css' => '67f4680d',
     'rsrc/css/application/conpherence/message-pane.css' => 'd244db1e',
-    'rsrc/css/application/conpherence/notification.css' => '6a3d4e58',
+    'rsrc/css/application/conpherence/notification.css' => '85c48def',
     'rsrc/css/application/conpherence/participant-pane.css' => '69e0058a',
     'rsrc/css/application/conpherence/transaction.css' => '3a3f5e7e',
     'rsrc/css/application/contentsource/content-source-view.css' => 'cdf0d579',
@@ -554,7 +554,7 @@ return array(
     'conpherence-header-pane-css' => 'c9a3db8e',
     'conpherence-menu-css' => '67f4680d',
     'conpherence-message-pane-css' => 'd244db1e',
-    'conpherence-notification-css' => '6a3d4e58',
+    'conpherence-notification-css' => '85c48def',
     'conpherence-participant-pane-css' => '69e0058a',
     'conpherence-thread-manager' => 'aec8e38c',
     'conpherence-transaction-css' => '3a3f5e7e',
diff --git a/webroot/rsrc/css/application/conpherence/notification.css b/webroot/rsrc/css/application/conpherence/notification.css
index 21e73047a6..fd24e775f1 100644
--- a/webroot/rsrc/css/application/conpherence/notification.css
+++ b/webroot/rsrc/css/application/conpherence/notification.css
@@ -84,3 +84,8 @@
   font-weight: normal;
   color: {$greytext};
 }
+
+/* On small devices the Persistent Chat is already hidden, and so its option */
+.device .phabricator-notification-header .persistent-option {
+  display: none;
+}